Skip to content

Fix typos in json_reporter documentation #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

FrankenApps
Copy link
Contributor

Fix two minor typos in the documentation for the json_reporter.

Several tools parse this documentation and therefore use the incorrect comments.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@FrankenApps FrankenApps requested a review from a team as a code owner May 4, 2025 13:44
Copy link

github-actions bot commented May 5, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@kevmoo
Copy link
Member

kevmoo commented May 5, 2025

Thanks, yo!

@kevmoo kevmoo merged commit 55d1f9e into dart-lang:master May 5, 2025
56 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 5, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/95105e9..e4f9451):
  e4f9451a  2025-05-05  Jonas Finnemann Jensen  Fix duplicate entries of elements in a category when re-exported. (dart-lang/dartdoc#4043)
  876180bd  2025-05-01  dependabot[bot]  Bump github/codeql-action from 3.28.13 to 3.28.16 in the github-actions group (dart-lang/dartdoc#4045)

http (https://github.com/dart-lang/http/compare/63c477b..78d6114):
  78d6114  2025-05-02  Brian Quinlan  Add a new exception type `NSErrorClientException` (dart-lang/http#1763)
  7a2e7d5  2025-05-01  Brian Quinlan  Add a useful stringificiation to `WebSocketConnectionClosed` (dart-lang/http#1764)
  ccb6533  2025-05-01  dependabot[bot]  Bump the github-actions group across 1 directory with 4 updates (dart-lang/http#1761)
  7568b5c  2025-05-02  Alex Li  [web_socket] Adds `WebSocketException.toString()` (dart-lang/http#1756)
  3e4cceb  2025-05-01  Brian Quinlan  Make response headers tests pass on firefox (dart-lang/http#1762)
  5704b0c  2025-05-01  Brian Quinlan  [cronet_http/cupertino_http]: Fixes bugs where cancelling `StreamedResponse.stream` did not sever the connection (dart-lang/http#1760)

test (https://github.com/dart-lang/test/compare/c3755d8..55d1f9e):
  55d1f9ed  2025-05-05  Fichtelcoder  Fix typos in json_reporter documentation (dart-lang/test#2493)

vector_math (https://github.com/google/vector_math.dart/compare/39cafd4..0279cb8):
  0279cb8  2025-05-01  Ömer Sinan Ağacan  Improve performance of functions with dynamic arguments (google/vector_math.dart#345)

Change-Id: I9a67b997ebcf7ebe29162f8f524628013d53af5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426581
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants