Skip to content

Implementation issue for constant changes Q4'18 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 18 tasks
mit-mit opened this issue Oct 25, 2018 · 4 comments
Closed
2 of 18 tasks

Implementation issue for constant changes Q4'18 #60

mit-mit opened this issue Oct 25, 2018 · 4 comments
Assignees
@lrhn
Labels
implementation Track the implementation of a specific feature OBSOLETE: Please use SDK issue
Milestone
Dart 2.4

Comments

@mit-mit
Copy link
Member

mit-mit commented Oct 25, 2018 •
edited by a-siva
Loading

This issue is for tracking implementation of a set of updates to the constant specification:

Request issue: #54
Feature issue: #61

Feature specification:
https://github.com/dart-lang/language/blob/master/accepted/future-releases/constant-update-2018/feature-specification.md

Implementation plan:
https://github.com/dart-lang/language/blob/master/accepted/future-releases/constant-update-2018/implementation-plan.md

ETA: Q4 2018 in Dart Repo.

Current Timing:
Phase 0: Mid November 2018
Phase 1: Early December 2018
Phase 2: Mid December 2018
Phase 3: Q1 2019

TODO/Dependencies [drafting and to be discussed with Leaf]

  • [] Discussion and feedback
  • [] Implementation team sign off (this issue):

*Phase 0 (Experimental Flags)

*Phase 1

*Phase 2

*Others:

  • Issue for updating documentation (TODO)
  • Comms / announcement (mit)
@mit-mit mit-mit added the implementation Track the implementation of a specific feature OBSOLETE: Please use SDK issue label Oct 25, 2018
@mit-mit mit-mit added this to the Dart 2.2 milestone Oct 25, 2018
@mit-mit mit-mit mentioned this issue Oct 25, 2018
Merged
This was referenced Nov 6, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@JekCharlsonYu
Copy link

Sign offs doc here:
https://docs.google.com/document/d/1brDDy48djKx4eWp8r_2u0rPD-vrrUE4U5QHi1r8nfqA/edit#

@JekCharlsonYu JekCharlsonYu mentioned this issue Nov 9, 2018
Closed
17 tasks
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 26, 2018
Add scanner and parser support for new >>> operator
52892f7 
This adds support for the new >>> operator as detailed in
https://github.com/dart-lang/language/blob/master/accepted/future-releases/constant-update-2018/feature-specification.md#new-operators

Tracking issue: dart-lang/language#60

Enable support by setting AbstractScanner.enableGtGtGt = true

Change-Id: I8e7d2fb341971452d8e05d734a1de612880fef5e
Reviewed-on: https://dart-review.googlesource.com/c/85421
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Dan Rubel <[email protected]>
@a-siva
Copy link

a-siva commented Mar 14, 2019

@lrhn should the milestone for this issue be moved to 2.3, I don't think this feature is fully implemented correct.

@a-siva a-siva mentioned this issue Mar 14, 2019
Closed
3 tasks
@lrhn
Copy link
Member

lrhn commented Mar 14, 2019

The CFE is still working on the feature. I hope it will make it into 2.3. If not, and we want to launch 2.3 anyway, we'll take it from there.

@a-siva a-siva modified the milestones: Dart 2.2, Dart 2.3 Mar 15, 2019
@leafpetersen leafpetersen modified the milestones: Dart 2.3, Dart 2.4 Apr 23, 2019
@leafpetersen
Copy link
Member

Moving to 2.4

@mit-mit mit-mit closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
implementation Track the implementation of a specific feature OBSOLETE: Please use SDK issue
Projects
None yet
Milestone
Dart 2.4
Development

No branches or pull requests
5 participants
@lrhn @leafpetersen @a-siva @mit-mit @JekCharlsonYu