Clarify boolean conditional evaluation #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmarkov
approved these changes
Apr 7, 2020
| and hence must be implicitly downcast to `bool`, after which no further check is | ||
| required. | ||
|
|
||
| In mixed mode (weak mode evaluation) Dart, values of type `Never` and `bool` may |
There was a problem hiding this comment.
In mixed mode (weak mode evaluation) Dart
It doesn't matter if it is mixed or not. Maybe simply 'In weak checking mode...'
|
Landing this. I'm working on tests to accompany, I will file issues for any failures. |
|
Tests out for review here: https://dart-review.googlesource.com/c/sdk/+/142782 |
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 10, 2020
Tests for the null safety spec clarification landed in dart-lang/language#917 . Change-Id: Ieafe5315c31919c01ff816a26d29fa0d1cbc8c9a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142782 Reviewed-by: Erik Ernst <[email protected]>
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 15, 2020
Partially reverts https://dart-review.googlesource.com/c/sdk/+/139402 but continues to throw a TypeError when running in strong mode. The breaking change to boolean conversions was not back-ported so we are still going to throw an AssertionError in weak mode. Updated Spec: dart-lang/language#917 Fixes: #41278 Change-Id: Ib50e9ab367f4a0c0f9f10c3e0fa4ec890ff9c2ae Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143007 Reviewed-by: Sigmund Cherem <[email protected]> Reviewed-by: Mark Zhou <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the behavior of boolean conditional expressions in strong and weak mode.
cc @nshahan @sigmundch @rakudrama @alexmarkov @lrhn @eernstg @munificent