[jni] Add JType.isA and JType.as to match ffigen's approach#3181
Open
imshubham22apr-gif wants to merge 2 commits intodart-lang:jni_extension_typesfrom
Open
[jni] Add JType.isA and JType.as to match ffigen's approach#3181imshubham22apr-gif wants to merge 2 commits intodart-lang:jni_extension_typesfrom
imshubham22apr-gif wants to merge 2 commits intodart-lang:jni_extension_typesfrom
Conversation
Contributor
|
@imshubham22apr-gif #3093 is a huge refactor to all this infra, so it would be best to wait for that to land before trying to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds isA and as methods to JType to match the approach used in
package:objective_c(ffigen). Since JNI classes are now extension types, standard Dart is and as checks are not reliable.Key changes:
JType.isAandJType.asfor safe runtime type checks and casting.JObject.isAandJObject.asto delegate to the new JType methods.Related Issues
Fixes #3175
Relates to #3174
PR Checklist
dart tool/ci.dart --alllocally (Note: Environment setup issue locally, relying on GitHub CI).