dependency_services #3304
dependency_services #3304
Conversation
lib/src/solver/report.dart
Outdated
| @@ -288,7 +288,7 @@ class SolveReport { | |||
| // Only show newer prereleases for versions where a prerelease is | |||
| // already chosen. | |||
| newId.version.isPreRelease && newerUnstable) { | |||
| message = '(${maxAll(versions)} available)'; | |||
| message = '(${maxAll(versions, Comparable.compare)} available)'; | |||
There was a problem hiding this comment.
I don't think we do. Not sure why this sneaked in.
| await listReportApply(context, [ | ||
| _PackageVersion('foo', Version.parse('2.2.3')), | ||
| _PackageVersion('transitive', null) | ||
| ]); |
There was a problem hiding this comment.
As much as I love golden tests, maybe we should add some assertions here?
There is a non-zero risk that we won't notice minor changes in the golden files.
If we could do a simple assertion like:
expect(report['dependencies'].any((depReport) => depReport['name'] == 'foo' && depReport['singleBreaking'].any(
(d) => d['name'] == 'transitive' && d['version'] == null),
), isTrue);Or something like that... just a few, we don't have to check every possible property :D
| -------------------------------- END OF OUTPUT --------------------------------- | ||
|
|
||
| ## Section apply | ||
| $ echo '{"dependencyChanges":[{"name":"foo","version":"3.0.1","constraint":"^3.0.0"},{"name":"bar","version":"2.0.0"}]}' | dependency_services apply |
There was a problem hiding this comment.
Shouldn't there also be a constraint for bar? Just asking... I'm not actually sure we require that... probably because dependabot loses this information...
There was a problem hiding this comment.
I don't think so. This is a single-breaking change. Only foo should have its constraint updated.
Also depandabot would lose this information
There was a problem hiding this comment.
I think this is the multibreaking example.... but yes dependabot will probably loose this information.
| @@ -17,7 +17,7 @@ Changed 1 dependency in myapp! | |||
| -------------------------------- END OF OUTPUT --------------------------------- | |||
|
|
|||
| ## Section 2 | |||
| $ pub -C myapp/example get --directory=myapp bar | |||
| $ pub -C 'myapp/example' get --directory=myapp bar | |||
There was a problem hiding this comment.
Should we do a tweak to escaping mechanism, so that we don't need to escape when there is a / or . in the string... those are generally safe in bash, right? (and quite common in our tests)
There was a problem hiding this comment.
Yeah we should.
The issue with / is a technical annoyance. We have test filter that turns '' into '/' in the golden tests on windows. But the escaping happens before...
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
This will provide support for dependabot resolution.
See dependabot/dependabot-core#4510 for usage.
This will not be exposed in the sdk.