Merge dependency services #3303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piping `stdin` to a `LineSplitter` and then using a `StreamQueue` causes event handler to wait for next characters after a line has been read. Hence, if we don't `exit()` explicitly or hit `stdin.close()` then the process will hang waiting for input on `stdin`. Using `stdin.readLineSync()` alleviates this issue. Having a timeout on prompts for tokens is nice, but only really required if we prompt while the solver is running. Which we probably won't need to do anyways, so not having a timeout is likely fine.
Piping `stdin` to a `LineSplitter` and then using a `StreamQueue` causes event handler to wait for next characters after a line has been read. Hence, if we don't `exit()` explicitly or hit `stdin.close()` then the process will hang waiting for input on `stdin`. Using `stdin.readLineSync()` alleviates this issue. Having a timeout on prompts for tokens is nice, but only really required if we prompt while the solver is running. Which we probably won't need to do anyways, so not having a timeout is likely fine.
Ensures that commit won't disappear from git in the future.
* Make globalPackageServer non-nullable * Remove unnecessary null assertions * Future -> Future<void> * Apply format
* Remove pedantic and cleanup a few lints * Do not use super as an object * Rename SolveType constants * Retain prefer_single_quotes * Rename to camelCase in log.dart
* Refactor notices/hints for solver conflicts. Untangled a lot of type assertions and digging into details of the incompatibility when printing the incompatibility. Notably, we introduce a concept of notices and hints. Notices are messages that an `IncompatibilityCause` can have, they are human readable messages printed before the incompatibility explanation. This allows `SdkCause` to point out the current version of an SDK that is causing a conflict (if the SDK is available). Hints are messages that an `IncompatibilityCause` can have, they are human readable message with actionable hints to be printed after the incompatibility explanation. This allows `PackageNotFoundCause` to hint that trying without `--offline` might work. Hints are printed after the incompatibility explanation because they actionable, they don't serve to explain what went wrong. They are intended to be actionable, hence, it's preferable the user sees these as one of the first things.
…g#3240) And also when given --verbose.
… in the environment. (dart-lang#3271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.