-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix ./tools/build.py on MacOSX to output to ./out instead of ./xcodebuild #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Added Area-Build, Triaged labels. |
The ninja build of dart, which uses the ninja build system rather than xcode, puts its output in out/ rather than xcodebuild/. This means that the test scripts will not work with a ninja build. I suggest that changing the build directory for xcode builds to out/ would allow scripts to work both with ninja and xcode builds. This is needed, if we want to allow people to start using ninja. To build with ninja, run: currently, the dart2js component does not build with ninja. |
All our current scripts works with the difference between win/mac/linux (build/xcodebuild/out) - I don't see any reason for changing this now (the only reason would be to support ninja (I don't see a big need for this, incremental builds are pretty fast in a small project like dart)) Set owner to @ricowind. |
Removed Area-Build label. |
Includes the following changes: a4bc2dd08630f85a94f506eab037fcaaedb42222 Rename --v2 to --dart-dev-run (#2498) 958862efa33605af3136c4bd366015bace62d869 Update outdated.dart (#2488) 2cc09730f73204afced1df606416c07d5ee1e67d outdated: work with no lock file (#2491) 7c73dae26df2b3ef3e3019d7296fd2871dd23c49 Do not fallback to bin/main.dart (#2478) 27bc4f7ef65928c95535baf51245fd5b01162d0f Preserve windows line endings in pubspec.lock if they are already there (#2489) 31cfec521db6fe607f0f0424e747dff2e4950711 pub outdated --mode=null-safety da05bbaee8c53b769d1f90458e28b3b7f9a22187 Fix `pub run` precompilation with relative PUB_CACHE paths (#2486) dd005e586fc17545f22fc6e75eedfc9f075f9092 Show summary count of outdated packages after running `pub upgrade` (#2444) 1b927956e653ea74a153513e593ff417617cabf0 Outdated: If current is a prerelease, use prereleases for latest if no newer stable (#2484) 678bd84a328fabb3fee360f837ac782f2831d753 Warn first time a package version opts in to null-safety (#2465) 8e76d46a4b8180ab247ecf6382f4f7abd34591f1 Force colors when --color is given (#2481) 572a23f815a5d632a8c2b259b691792674cd8b4d Rely on terminal telling if we can use colors (#2475) 363ed6fe54c084df43bbec1704757d0d6c64cbb7 pub run --v2 for use in dartdev (#2435) aa5bbbb7261fc492866b5d6b94357cbe8df5e09a Use a 8-bit ansi palette for grey (#2474) 3929b1138a589b4f506018d98b3005a3e76dcea6 Format with new dartfmt (#2476) 6deb457048deb435009b36a4cd2d86003d107cf4 Use line length to wrap usage (#2457) 6e2ce2e4add80c4e15c8346a976cbf760d707f6a Use gzip decoder from dart:io. (#2382) 5b5fe72a33a66e4cab7070b3248596877e3a854e Improve the `pub outdated --help` text (#2429) Change-Id: If9a719bfc374f085bd26856330547682c14f0df4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148532 Reviewed-by: Jonas Jensen <[email protected]> Commit-Queue: Jonas Jensen <[email protected]>
This issue was originally filed by @financecoding
What steps will reproduce the problem?
What is the expected output? What do you see instead?
Expecting build output to ./out directory, instead of xcodebuild. Most of the time I would just create a symbolic link ln -s xcodebuild out , but some scripts fail to resolve correctly (Maybe this is a totally different bug with utils.GetDartRunner not able to resolve symbolic links)
What version of the product are you using? On what operating system?
23:13:14-adam@Adams-MacBook-Air:~/dart_bleeding/dart
$ svn info .
Path: .
URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Repository Root: http://dart.googlecode.com/svn
Repository UUID: 260f80e4-7a28-3924-810f-c04153c831b5
Revision: 6310
Node Kind: directory
Schedule: normal
Last Changed Author: [email protected]
Last Changed Rev: 6310
Last Changed Date: 2012-04-07 14:26:07 -0700 (Sat, 07 Apr 2012)
23:13:16-adam@Adams-MacBook-Air:
/dart_bleeding/dart1/RELEASE_X86_64 x86_64$ uname -a
Darwin Adams-MacBook-Air.local 11.3.0 Darwin Kernel Version 11.3.0: Thu Jan 12 18:47:41 PST 2012; root:xnu-1699.24.23
Please provide any additional information below.
The text was updated successfully, but these errors were encountered: