Skip to content

dartdoc should display type parameter references #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Apr 27, 2012 · 7 comments
Closed

dartdoc should display type parameter references #2781

DartBot opened this issue Apr 27, 2012 · 7 comments
Assignees
@munificent
Milestone
M1

Comments

@DartBot
Copy link

DartBot commented Apr 27, 2012

This issue was originally filed by @seaneagan

Currently for generic classes and interfaces, dartdoc does not display type parameter references used in constructors / members / method parameters / return types. For example, Collection#filter is declared as:

Collection<E> filter(bool f(E element));

but the HTML generated by dartdoc only displays:

Collection filter(bool f(element));

which makes it look like filter returns a Collection<Dynamic>
@dgrove
Copy link
Contributor

dgrove commented Apr 27, 2012

Set owner to @munificent.
Added Triaged label.

@anders-sandholm
Copy link
Contributor

Added Area-DartDoc label.

@sethladd
Copy link
Contributor

sethladd commented Jun 1, 2012

Issue #2911 has been merged into this issue.

@munificent
Copy link
Member

Added this to the M1 milestone.

@sethladd
Copy link
Contributor

sethladd commented Jun 6, 2012

Marked this as being blocked by #3414.

@kevmoo
Copy link
Member

kevmoo commented Jun 16, 2012

Dupe of http://code.google.com/p/dart/issues/detail?id=1483

...although 1483 only references return types while I agree it'd be nice to have generics everywhere.

@johnniwinther
Copy link
Member

Fixed by http://codereview.chromium.org/10701091/

Added Fixed label.
Marked this as being blocked by #3414.
Unmarked this as being blocked by #3414.

@DartBot DartBot added this to the M1 milestone Jul 13, 2012
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
dart-bot pushed a commit that referenced this issue Dec 7, 2020
@jonasfj
Roll pub
41381e9 
a7e448b2 pub upgrade --major-versions (#2784)
06bcff09 pub upgrade foo, only unlocks foo from pubspec.lock (#2781)
aa20a4bd Usage exceptions no stacktrace (#2776)
14e12bf6 Clarify error message when spawning a subprocess fails (#2763)
5ef0a0e7 Added a pub upgrade --nullsafety mode (#2741)
9cde2406 Fix pub remove --dry-run (#2774)
7426be94 Remove hack now issue has been fixed (#2773)
90a1f776 Limit retries in test to avoid timeout (#2765)
3aa327c7 Stop depending on .packages (#2764)

Change-Id: Ifd8a8402c4628e7278b6fedfd2ca7902004fa6e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175241
Auto-Submit: Jonas Jensen <[email protected]>
Reviewed-by: Sigurd Meldgaard <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
dart-bot pushed a commit that referenced this issue Dec 8, 2020
@davidmorgan
Revert "Roll pub"
c0e13c1 
This reverts commit 41381e9.

Reason for revert: pub fails on startup if git is not installed; b/175080640

Original change's description:
> Roll pub
>
> a7e448b2 pub upgrade --major-versions (#2784)
> 06bcff09 pub upgrade foo, only unlocks foo from pubspec.lock (#2781)
> aa20a4bd Usage exceptions no stacktrace (#2776)
> 14e12bf6 Clarify error message when spawning a subprocess fails (#2763)
> 5ef0a0e7 Added a pub upgrade --nullsafety mode (#2741)
> 9cde2406 Fix pub remove --dry-run (#2774)
> 7426be94 Remove hack now issue has been fixed (#2773)
> 90a1f776 Limit retries in test to avoid timeout (#2765)
> 3aa327c7 Stop depending on .packages (#2764)
>
> Change-Id: Ifd8a8402c4628e7278b6fedfd2ca7902004fa6e8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175241
> Auto-Submit: Jonas Jensen <[email protected]>
> Reviewed-by: Sigurd Meldgaard <[email protected]>
> Commit-Queue: Sigurd Meldgaard <[email protected]>

[email protected],[email protected]

Change-Id: I29b20b4a2dc037146dd27c8fe6e6ecce6833e7b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175303
Reviewed-by: David Morgan <[email protected]>
Commit-Queue: David Morgan <[email protected]>
dart-bot pushed a commit that referenced this issue Dec 9, 2020
@sigurdm
Reland "Roll pub"
bf26eb3 
This is a reland of 41381e9

Contains one more fix:
8ea96121d fix tryGitCommand

Original change's description:
> Roll pub
>
> a7e448b2 pub upgrade --major-versions (#2784)
> 06bcff09 pub upgrade foo, only unlocks foo from pubspec.lock (#2781)
> aa20a4bd Usage exceptions no stacktrace (#2776)
> 14e12bf6 Clarify error message when spawning a subprocess fails (#2763)
> 5ef0a0e7 Added a pub upgrade --nullsafety mode (#2741)
> 9cde2406 Fix pub remove --dry-run (#2774)
> 7426be94 Remove hack now issue has been fixed (#2773)
> 90a1f776 Limit retries in test to avoid timeout (#2765)
> 3aa327c7 Stop depending on .packages (#2764)
>
> Change-Id: Ifd8a8402c4628e7278b6fedfd2ca7902004fa6e8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175241
> Auto-Submit: Jonas Jensen <[email protected]>
> Reviewed-by: Sigurd Meldgaard <[email protected]>
> Commit-Queue: Sigurd Meldgaard <[email protected]>

Change-Id: Id50e6eca0372860f7087882a5c67141def07031c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175309
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
None yet
Projects
None yet
Milestone
M1
Development

No branches or pull requests
7 participants
@sethladd @kevmoo @munificent @dgrove @anders-sandholm @DartBot @johnniwinther