Skip to content

html: Fix broken $dom_xxx field members #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rakudrama opened this issue Apr 30, 2012 · 2 comments
Closed

html: Fix broken $dom_xxx field members #2834

rakudrama opened this issue Apr 30, 2012 · 2 comments
Assignees
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable

Comments

@rakudrama
Copy link
Member

Some fields have $dom_ names. This won't work.

  /** @­domName HTMLElement.children */
  final HTMLCollection $dom_children;

  /** @­domName HTMLElement.className */
  String $dom_className;

Suggestion: add native renaming to field declarations:

  String $dom_className native 'className';

This will require fixing frog and dart2js to parse the construct and pass through the js name.
The benefit to the compiler is that it now knows 'className' is special so should not be used as the js name of a Dart field.

It would be possible to use getters and setters with frog-style native bodies.
This will be a net performance loss in frog since there is no inlining.
It also creates more frog-style bodies that will need to eventually be rewritten.

@rakudrama
Copy link
Member Author

Marked this as blocking #2777.

@rakudrama
Copy link
Member Author

I misread the code.
It looks like the all the relevant code is implemented as getters.

I'm closing this issue since they are not 'broken'.


Removed Priority-High label.
Added Priority-Medium, Invalid labels.

@rakudrama rakudrama added Type-Defect closed-invalid Closed as we don't believe the reported issue is generally actionable labels May 1, 2012
@rakudrama rakudrama self-assigned this May 1, 2012
dart-bot pushed a commit that referenced this issue Jan 22, 2021
Notable changes:
 * Highlight about _discontinued_ dependencies in `dart pub get`.

git log --oneline c55fc832...392a3cb4
c55fc832 No metadata when CI=true (#2837)
a95ff4b1 Warn about discontinued packages on pub get/upgrade (#2835)
135bf942 Allow package_config.json to contain flutter_gen (#2830)
6a60b0ee output of command 'dart pub upgrade' updated (#2834)
6b6c4206 Mention `dart pub` (#2823)
a94e1c2c Add GitHub Actions workflow (#2802)

Change-Id: Iec09f3290cc8a4e21505c3ef7b4aec820a210d93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180563
Auto-Submit: Jonas Jensen <[email protected]>
Reviewed-by: Michael Thomsen <[email protected]>
Reviewed-by: Sigurd Meldgaard <[email protected]>
Commit-Queue: Michael Thomsen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable
Projects
None yet
Development

No branches or pull requests

1 participant