You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggestion: add native renaming to field declarations:
String $dom_className native 'className';
This will require fixing frog and dart2js to parse the construct and pass through the js name.
The benefit to the compiler is that it now knows 'className' is special so should not be used as the js name of a Dart field.
It would be possible to use getters and setters with frog-style native bodies.
This will be a net performance loss in frog since there is no inlining.
It also creates more frog-style bodies that will need to eventually be rewritten.
The text was updated successfully, but these errors were encountered:
Some fields have $dom_ names. This won't work.
/** @domName HTMLElement.children */
final HTMLCollection $dom_children;
/** @domName HTMLElement.className */
String $dom_className;
Suggestion: add native renaming to field declarations:
String $dom_className native 'className';
This will require fixing frog and dart2js to parse the construct and pass through the js name.
The benefit to the compiler is that it now knows 'className' is special so should not be used as the js name of a Dart field.
It would be possible to use getters and setters with frog-style native bodies.
This will be a net performance loss in frog since there is no inlining.
It also creates more frog-style bodies that will need to eventually be rewritten.
The text was updated successfully, but these errors were encountered: