Skip to content

DDC needs to implement the changes of lang/#807 #40720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crelier opened this issue Feb 21, 2020 · 2 comments
Closed

DDC needs to implement the changes of lang/#807 #40720

crelier opened this issue Feb 21, 2020 · 2 comments
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. dev-compiler-test NNBD Issues related to NNBD Release web-dev-compiler

Comments

@crelier
Copy link
Contributor

crelier commented Feb 21, 2020

There are new test failures on [VM/nnbd] Implement pre-nnbd language changes (see lang/#807)..

The tests

corelib/type_tostring_test RuntimeError (expected Pass)
corelib_2/type_tostring_test RuntimeError (expected Pass)

are failing on configurations

dartdevk-checked-linux-release-chrome
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome

These tests have been updated (in CL above) to pass on the VM when implementing the changes of lang/#807.
Until DDC implements the same changes, these 2 updated tests will fail.
@crelier crelier added dev-compiler-test NNBD Issues related to NNBD Release labels Feb 21, 2020
@mraleph mraleph added the area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. label Feb 25, 2020
@mraleph
Copy link
Member

mraleph commented Feb 25, 2020

/cc @sigmundch

@nshahan nshahan self-assigned this Feb 25, 2020
@sigmundch sigmundch added area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dev-compiler and removed area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. labels Feb 25, 2020
dart-bot pushed a commit that referenced this issue Mar 3, 2020
@nshahan
[dartdevc] Add normalization of FutureOr types
ab30452 
These changes are also being back ported into the existing SDK
with minimal differences that will be gone when we unfork the
dart:_runtime library. In the current back port:
* FutureOr<Null>? is normalized to Future<Null>* instead of
  Future<Null>?.
* There is no runtime normalization of FutureOr<T?>?. This
  should have no effect since nullable types can not yet
  appear.

Fixes: #40611, #40720
Change-Id: Ib3ddffbf3778f0f571cf95f58b6142d3ee0bf59b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136160
Reviewed-by: Sigmund Cherem <[email protected]>
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
@sigmundch
Copy link
Member

This was fixed by ab30452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. dev-compiler-test NNBD Issues related to NNBD Release web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mraleph @sigmundch @nshahan @crelier