Skip to content

[Patterns] Analysis server / IDE support work #49759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
29 tasks done
itsjustkevin opened this issue Aug 19, 2022 · 4 comments
Closed
29 tasks done

[Patterns] Analysis server / IDE support work #49759

itsjustkevin opened this issue Aug 19, 2022 · 4 comments
Assignees
@bwilkerson
Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone
Dart 3 beta 3

Comments

@itsjustkevin
Copy link
Contributor

itsjustkevin commented Aug 19, 2022 •
edited by keertip
Loading

This is the issue tracking the work that needs to be done in the analysis server to support the patterns feature. If you decide to work on a feature, either create an issue for the feature and link to it from here, or put your name beside the feature so that we don't duplicate effort.

  • Call Hierarchy
    Need tests to ensure that invocations within patterns are found.
    (keertip)
  • Closing Labels
    (brianwilkerson, NA)
  • Code Completion
    • Need tests to ensure that completion works within patterns.
    • Need tests to ensure that variables introduced by patterns are suggested where appropriate.
    • Need to propose new keywords. (brianwilkerson)
  • Code Folding
    Decide whether we want to fold switch expressions.
    (@pq)
  • documentSymbol
    (brianwilkerson, NA)
  • Flutter Outline
    (brianwilkerson, NA)
  • Hovers
    Need tests to ensure that hovers work in patterns.
    (dantup)
  • Implemented Markers
    (brianwilkerson, NA)
  • Navigation
    Need tests to ensure that navigation works in patterns.
    (keertip)
  • Occurrences
    Need tests to ensure that referenced within patterns are found.
    (dantup)
  • Organize Imports
    (brianwilkerson, NA)
  • Outline
    (brianwilkerson, NA)
  • Overrides Markers
    (brianwilkerson, NA)
  • Quick Assists and Fixes
    Quick Assists and Fixes for Patterns #49960
  • Refactorings - legacy
    (brianwilkerson, NA)
  • Refactorings - self describing
    (brianwilkerson, NA)
  • Search - Find References
    Need tests to ensure that referenced within patterns are found.
    (dantup)
  • Search - Member Declarations
    (brianwilkerson, NA)
  • Search - Member References
    (dantup)
  • Search - Top-level Declarations
    (brianwilkerson, NA)
  • selectionRange
    Needs to be extended to support pattern nodes.
    (dantup)
  • Semantic Highlights
    (brianwilkerson)
  • signatureHelp
    (brianwilkerson, NA)
  • Snippets
    Decide whether we want to add a snippet for switch expressions.
    (dantup)
  • Sort Members
    (brianwilkerson, NA)
  • Type Hierarchy
    (brianwilkerson, NA)
@bwilkerson bwilkerson added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. devexp-server Issues related to some aspect of the analysis server labels Aug 19, 2022
@stereotype441 stereotype441 mentioned this issue Nov 30, 2022
Open
@srawlins srawlins modified the milestones: Dart 3 stable, Dart 3 beta 2 Nov 30, 2022
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Feb 7, 2023
@pq
Copy link
Member

pq commented Feb 15, 2023

RE: code-folding, we don't currently for standard switches so I'd say we not rush to implement it for switch expressions. If the need arises we can revisit.

@bwilkerson
Copy link
Member

sgtm

@keertip
Copy link
Contributor

keertip commented Mar 28, 2023

@bwilkerson , can we close this issue?

@bwilkerson
Copy link
Member

Yes. Done.

copybara-service bot pushed a commit that referenced this issue May 26, 2023
@scheglov
Issue 49759. Keep only 2.19 tests in RemoveDuplicateCaseTest.
8702f09 
The corresponding lint is no-op in 3.0
https://github.com/dart-lang/linter/issues/3674

Bug: #49759
Change-Id: I24fd82240d8e94e763742c546ec2d4cf3c4df8cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306126
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
Dart 3 beta 3
Development

No branches or pull requests
5 participants
@pq @srawlins @keertip @bwilkerson @itsjustkevin