Skip to content

Quick Assists and Fixes for Patterns #49960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
pq opened this issue Sep 13, 2022 · 13 comments
Closed
3 tasks done

Quick Assists and Fixes for Patterns #49960

pq opened this issue Sep 13, 2022 · 13 comments
Assignees
@pq @keertip @bwilkerson
Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Milestone
Dart 3 beta 3

Comments

@pq
Copy link
Member

pq commented Sep 13, 2022 •
edited
Loading

A meta-issue to discuss and track server work on quick assists and fixes for patterns.

CorrectionProducers to Review/Test/Update

  • RemoveDuplicateCase
  • UseCurlyBraces

New Assists
@pq pq mentioned this issue Sep 13, 2022
Closed
29 tasks
@pq pq assigned pq and bwilkerson Sep 13, 2022
@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. devexp-server Issues related to some aspect of the analysis server labels Sep 13, 2022
@pq pq changed the title Quick Assists and Fixes Quick Assists and Fixes for Patterns Sep 13, 2022
@srawlins srawlins added this to the Dart 3 stable milestone Nov 30, 2022
@srawlins srawlins added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Nov 30, 2022
@srawlins srawlins modified the milestones: Dart 3 stable, Dart 3 beta 3 Nov 30, 2022
@bwilkerson
Copy link
Member

Actually, I think we need to review all of them, don't we? Or are those the only two you think need tests / bug fixes?

@pq
Copy link
Member Author

pq commented Jan 5, 2023

We do. Those were just two that popped out as likely needing updates (I think?)

@keertip
Copy link
Contributor

keertip commented Jan 11, 2023 •
edited
Loading

Other fixes/assists to be looked at:

  • add_const
    • partially done, as the diagnostics needed for the fix are not being produced
    • blocked on FE issues #50947, #50996, #51139
  • remove_question_mark
  • remove_var
  • replace_if_else_with_conditional
  • remove_non_null_assertion

@pq
Copy link
Member Author

pq commented Jan 11, 2023 •
edited
Loading

It'd be great to add a

too to associate w/ unnecessary_breaks (#58860)

copybara-service bot pushed a commit that referenced this issue Feb 1, 2023
@keertip
Wire up remove var and replace if else with conditional for patterns
8353966 
BUG=#49960

Change-Id: I1a2d6e69127d4d82ed2cd4a121572d0ff6c3af82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280200
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 7, 2023
@pq
+ remove_break fix (for unnecessary_breaks)
2192131 
See: #49960

Change-Id: I67f3e58030aa800bebc045fc86114a5d9e5f7522
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281464
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@pq
Copy link
Member Author

pq commented Feb 8, 2023 •
edited
Loading

We'll also want fixes for invalid_case_patterns (#59027) which may be as simple as associating add_const?

@keertip
Copy link
Contributor

keertip commented Feb 9, 2023

Updated error_fix_status.yaml with no fix/needs fix status for diagnostics related to patterns.

copybara-service bot pushed a commit that referenced this issue Feb 9, 2023
@pq
invalid_case_patterns fix
e62699c 
See: #49960

Change-Id: I5ada583d5353521fe863d639bbad85691ca953ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281870
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
@itsjustkevin
Copy link
Contributor

@keertip and @pq are we still blocked here on the issues noted above?

@pq
Copy link
Member Author

pq commented Mar 6, 2023

Taking a quick look at the FE issues listed above. I think they're still open so I'm guessing add_const is still incomplete. @keertip?

@keertip
Copy link
Contributor

keertip commented Mar 9, 2023 •
edited
Loading

add_const work is now complete, no longer blocked on any issue.

@keertip
Copy link
Contributor

keertip commented Mar 9, 2023

@pq, do you have any pending work for this issue. If not we can close it.

@pq
Copy link
Member Author

pq commented Mar 10, 2023

Yep. I'm close to done w/ #50417. Once that lands we can close this out?

@keertip
Copy link
Contributor

keertip commented Mar 10, 2023

Yes, we can!

@scheglov
Copy link
Contributor

There is still a failing test that annotated with this issue.

@scheglov scheglov reopened this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

@keertip keertip

@bwilkerson bwilkerson

Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart 3 beta 3
Development

No branches or pull requests
6 participants
@pq @srawlins @scheglov @keertip @bwilkerson @itsjustkevin