[pkg:js] Disallow users from using synthetic constructors for @staticInterop #49941
Assignees
Labels
area-web-js
Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.
web-js-interop
Issues that impact all js interop
Comments
srujzs
added
web-js-interop
srujzs
added a commit
to srujzs/engine
that referenced
this issue
Nov 8, 2022
…c constructor Per dart-lang/sdk#49941, synthetic constructors will be disallowed on @staticInterop classes. Functionally, they are lowered to the same code. Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the relevant factory method.
8 tasks
srujzs
added a commit
to srujzs/engine
that referenced
this issue
Nov 9, 2022
…c constructor Per dart-lang/sdk#49941, synthetic constructors will be disallowed on @staticInterop classes. Functionally, they are lowered to the same code. Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the relevant factory method.
joshualitt
pushed a commit
to flutter/engine
that referenced
this issue
Nov 10, 2022
…c constructor (#37443) Per dart-lang/sdk#49941, synthetic constructors will be disallowed on @staticInterop classes. Functionally, they are lowered to the same code. Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the relevant factory method.
8 tasks
schwa423
pushed a commit
to schwa423/engine
that referenced
this issue
Nov 16, 2022
…c constructor (flutter#37443) Per dart-lang/sdk#49941, synthetic constructors will be disallowed on @staticInterop classes. Functionally, they are lowered to the same code. Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the relevant factory method.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, users can write interop classes and call synthetic constructors and they will hit no checks. In the Wasm case, generative constructors are a pain point, so a synthetic constructor should be disallowed. Synthetic constructors should compile to the same code as factories with and without the
@anonymousannotation. We should check for invocations of synthetic constructors and disallow them and advise them to use non-synthetic constructors instead.Related:
#48730
#49350
cc @sigmundch @joshualitt
The text was updated successfully, but these errors were encountered: