-
Notifications
You must be signed in to change notification settings - Fork 6k
Add external factories for @staticInterop classes instead of synthetic constructor #37443
Conversation
Gold has detected about 103 new digest(s) on patchset 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
test-exemption: code refactor with no semantic change |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…c constructor Per dart-lang/sdk#49941, synthetic constructors will be disallowed on @staticInterop classes. Functionally, they are lowered to the same code. Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the relevant factory method.
…f synthetic constructor (flutter/engine#37443)
…115048) * 7a746dd9c Add external factories for @staticInterop classes instead of synthetic constructor (flutter/engine#37443) * b42ed6933 Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#37486)
…c constructor (flutter#37443) Per dart-lang/sdk#49941, synthetic constructors will be disallowed on @staticInterop classes. Functionally, they are lowered to the same code. Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the relevant factory method.
…lutter#115048) * 7a746dd9c Add external factories for @staticInterop classes instead of synthetic constructor (flutter/engine#37443) * b42ed6933 Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#37486)
…lutter#115048) * 7a746dd9c Add external factories for @staticInterop classes instead of synthetic constructor (flutter/engine#37443) * b42ed6933 Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#37486)
Per dart-lang/sdk#49941, synthetic constructors will be disallowed on @staticInterop classes. Functionally, they are lowered to the same code.
Also fixes an erroneous call to the DomHTMLStyleConstructor instead of the relevant factory method.
Migration needed to fix dart-lang/sdk#49941
These factories were added because they were caught by the flutter trybots (https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8798044738469408369/+/u/build_host_debug/stdout).
Pre-launch Checklist
///
).