Skip to content

trigger error for const A(B()) if B non-const #33515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

trigger error for const A(B()) if B non-const #33515

wants to merge 4 commits into from

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Jun 20, 2018

To unblock #57706

bwilkerson
bwilkerson reviewed Jun 20, 2018
View reviewed changes
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually want to fix test_constructorInvocation_noArgs by adding an explicit const constructor, and then add the test resulting from your changes (where there's an error) as something like test_constructorInvocation_noConstConstructor.

@dart-bot dart-bot closed this in b343d0a Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a14n @bwilkerson @googlebot