trigger error for const A(B()) if B non-const

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -417,6 +417,11 @@ class ConstantEvaluationEngine {
       ConstantVisitor constantVisitor,
       ErrorReporter errorReporter,
       {ConstructorInvocation invocation}) {
+    if (!constructor.isConst) {
+      errorReporter.reportErrorForNode(
+          CompileTimeErrorCode.CONST_WITH_NON_CONST, node);
+      return null;
+    }
     if (!getConstructorImpl(constructor).isCycleFree) {
       // It's not safe to evaluate this constructor, so bail out.
       // TODO(paulberry): ensure that a reasonable error message is produced

pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart

@@ -537,6 +537,13 @@ class CompileTimeErrorCodeTest_Kernel extends CompileTimeErrorCodeTest_Driver {
     await super.test_constWithNonConst_with();
   }
 
+  @override
+  @failingTest
+  test_constWithNonConst_in_const_context() async {
+    // Bad state: No data for () at 58
+    await super.test_constWithNonConst_in_const_context();
+  }
+
   @override
   @failingTest
   test_constWithNonConstantArgument_annotation() async {

pkg/analyzer/test/generated/compile_time_error_code_test.dart

@@ -1613,7 +1613,33 @@ main() {
 }
 ''');
     await computeAnalysisResult(source);
-    assertErrors(source, [CompileTimeErrorCode.CONST_WITH_NON_CONST]);
+    // TODO(a14n): the error CONST_INITIALIZED_WITH_NON_CONSTANT_VALUE is
+    // redundant and ought to be suppressed.
+    assertErrors(source, [
+      CompileTimeErrorCode.CONST_WITH_NON_CONST,
+      CompileTimeErrorCode.CONST_INITIALIZED_WITH_NON_CONSTANT_VALUE
+    ]);
+    verify([source]);
+  }
+
+  test_constWithNonConst_in_const_context() async {
+    Source source = addSource(r'''
+class A {
+  const A(x);
+}
+class B {
+}
+main() {
+  const A(B());
+}
+''');
+    await computeAnalysisResult(source);
+    // TODO(a14n): the error CONST_WITH_NON_CONSTANT_ARGUMENT is redundant and
+    // ought to be suppressed.
+    assertErrors(source, [
+      CompileTimeErrorCode.CONST_WITH_NON_CONST,
+      CompileTimeErrorCode.CONST_WITH_NON_CONSTANT_ARGUMENT
+    ]);
     verify([source]);
   }
 

pkg/analyzer/test/generated/constant_test.dart

@@ -188,13 +188,21 @@ class C {
 
   void test_constructorInvocation_noArgs() {
     EvaluationResult result =
-        _getExpressionValue("const C()", context: 'class C {}');
+        _getExpressionValue("const C()", context: 'class C {const C();}');
     expect(result.isValid, isTrue);
     DartObject value = result.value;
     expect(value, isNotNull);
     expect(value.type.name, 'C');
   }
 
+  void test_constructorInvocation_noConstConstructor() {
+    EvaluationResult result =
+        _getExpressionValue("const C()", context: 'class C {}');
+    expect(result.isValid, isFalse);
+    DartObject value = result.value;
+    expect(value, isNull);
+  }
+
   void test_constructorInvocation_simpleArgs() {
     EvaluationResult result = _getExpressionValue("const C(1)", context: '''
 class C {