Add support for reporting whether an element has Unsafe annotation #40430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL is a code cleanup landed separately from https://dart-review.googlesource.com/c/sdk/+/129081 to make the CL size smaller. Refactorings: * Split up runtime/vm/compiler/ffi.{cc,h} in multiple files. * Move FrameRebase to compiler/ffi and prevent it from modifying Locations. * Remove use of <algorithm>. Change-Id: Ice2a96470a3242a731255383b9647fabab107ac5 Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,dart-sdk-linux-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,front-end-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133224 Commit-Queue: Daco Harkes <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
The List constructor has been disallowed in NNBD code, so the NNBD SDK should not be using it. This changes all uses, not just in the already migrated libraries. (Also found some bad typing in the `RegExpMatch` class along the way). Change-Id: Ic61bd64427c0961c23aaf7ce59af5c2c271890ef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132282 Commit-Queue: Lasse R.H. Nielsen <[email protected]> Reviewed-by: Bob Nystrom <[email protected]>
Change-Id: Ic6a75b4711665c82449709df1e44b474261416f3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132845 Auto-Submit: Erik Ernst <[email protected]> Commit-Queue: Johnni Winther <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
The `moveNext` docs should contain all the information necessary to implement it. There is otherwise no mention that this method is also used to set `current` to the initial element. Closes dart-lang#39676 dart-lang#39676 GitOrigin-RevId: c921486 Change-Id: I06736889c6e904e17027f27b7c5831eff495ce1b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127455 Reviewed-by: Lasse R.H. Nielsen <[email protected]> Commit-Queue: Lasse R.H. Nielsen <[email protected]>
…he ProgramCompiler constructor, and remove the corresponding arguments from emitModule. This allows these maps to be re-used across multiple instances. Change-Id: I433538d88dbe0348e2cfa592dae2e17af3dc17b4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133150 Reviewed-by: Mark Zhou <[email protected]> Commit-Queue: Jake Macdonald <[email protected]>
Change-Id: Ief1a795fdf6b52a77c43ed0435d96bb4350fd1f9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133202 Reviewed-by: Paul Berry <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
Change-Id: I57226491571272aa483aec8b5e14dc00c55511ed Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132812 Commit-Queue: Mark Zhou <[email protected]> Reviewed-by: Lasse R.H. Nielsen <[email protected]> Reviewed-by: Sigmund Cherem <[email protected]>
When file watching stream reports an error, it will close the handle too after sending "closed" event out to the listeners. Listener should not attempt to do anything with that handle(kept as pathId in the listener). In particular it should not attempt to call that handle to unwatch when user of the listener requested to cancel the listener. Further fixes for flutter/flutter#46616 Change-Id: Iccc100e294b11d3999ad68e775ef1ceb1d7a5efb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133180 Commit-Queue: Alexander Aprelev <[email protected]> Reviewed-by: Zichang Guo <[email protected]>
Change-Id: I497f48ee0930829adf44a510101181578a4a9c86 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133242 Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
Change-Id: I4d21d7fae09dd4ed861e560d53fec7b86ed01173 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133141 Reviewed-by: Nicholas Shahan <[email protected]> Commit-Queue: Sigmund Cherem <[email protected]>
Fixes: https://github.com/dart-lang/linter/issues/1986 Change-Id: I67ba3393be48dc39d3bbaaa922542f11b138afae Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133244 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Phil Quitslund <[email protected]>
Change-Id: I784cccddaa244c972c44e9b37896ff48161b5ce5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133168 Commit-Queue: Siva Annamalai <[email protected]> Reviewed-by: Alexander Markov <[email protected]>
This is a reland of 8a8c19d Fix the memory leak of namespace. Original change's description: > [vm] resolve symbolic link to find kernel_service snapshot > > When VM starts, it will try to find kernel service snapshot which is located together with exe file. However, if symbolic link is provided, the directory to search will become the parent directory of link but not the actual target. > This cl will resolve the symbolic link to find the kernel service snapshot. > > Bug: dart-lang#35188 > Change-Id: I842973a9b73439003a748122d9416158d155892e > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129380 > Commit-Queue: Zichang Guo <[email protected]> > Reviewed-by: Siva Annamalai <[email protected]> Bug: dart-lang#35188 Change-Id: I45f09d3ec813926b72d79880aeee2cc8a0453f87 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133246 Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Zichang Guo <[email protected]>
When migrating, we'll need to change some null-aware property accesses and method calls to non-null-aware (due to the fact that the receiver is non-nullable, or due to the new `?.` shortcut rules), so when migration re-resolves, it will need to be able to override resolution's determination of whether a given property access or method call is null-aware. Change-Id: I411f43fb937431e757d4dd9b968874db84158e47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133240 Reviewed-by: Konstantin Shcheglov <[email protected]>
Change-Id: Id32f60caec0c25099704652c03fafc8b184bf4d8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133241 Reviewed-by: Mike Fairhurst <[email protected]> Commit-Queue: Paul Berry <[email protected]>
This works on all browsers, in d8, and supports both dartdevk and dart2js. In the case of dart2js, this also expands minified names and inlined data. The result is presented to users as a separate section, so the original JS stack trace is printed as is, and a second deobfuscated stack trace is printed afterwards. Change-Id: I10af5e0241a8c87ad8db48234ce52cfb51a27411 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132966 Commit-Queue: Sigmund Cherem <[email protected]> Reviewed-by: Vijay Menon <[email protected]> Reviewed-by: Bob Nystrom <[email protected]>
TBR: [email protected] Change-Id: Ib7693ebbd874ee35a0388416c669397ff3505ecc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133282 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Stephen Adams <[email protected]>
Change-Id: Idc99607693cc52550f0012828e93153a002ef718 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133280 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Stephen Adams <[email protected]>
Move tests from tests/lib_2/profiler to tests/lib_2/developer since `dart:profiler` no longer exists. Bug: dart-lang#40142 Change-Id: Iccf68ea2922caa52122d48c91fe5fa35a241b051 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133281 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
…tract methods. Opens new issue: dart-lang/co19#516 Bug: dart-lang#40287 Change-Id: Ifd05e570b8411369cec296db52746ce4f144bbac Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133201 Reviewed-by: Paul Berry <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Work towards flutter/flutter#46724 Background: on the latest versions of iOS today, we have to use mdns to discover the observatory port and authentication code. For a variety of reasons this can fail, leaving us with no way to connect. An alternative approach is to specify the observatory port and disable the authentication code. If binding to this port fails, however, we would still like to attempt connecting with mdns. Overview: This adds a new flag to the dart SDK, --enable-service-port-fallback. This amends the behavior of the vmservice with a specified port. After failing to bind once to a non-zero port, update the port selection to 0. Results: Tested locally two dart VMs with the same specified port: ``` jonahwilliams@jonahwilliams0:~/Documents/engine/src/out/host_debug_unopt$ ./dart --enable-service-port-fallback --observe=8080 example.dart Observatory server failed to start after 1 tries Falling back to automatic port selection vm-service: isolate(2785434094928835) 'main' has no debugger attached and is paused at exit. Connect to Observatory to debug. Observatory listening on http://127.0.0.1:45663/62A5IHjmv9E=/ ``` Change-Id: I371583edcb603325428f1cb760992e39b9f3b6dc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130441 Commit-Queue: Jonah Williams <[email protected]> Reviewed-by: Ben Konyi <[email protected]>
Issue: dart-lang#40275 Change-Id: I78e5a8843e36599cbac8b2f838d3e11d9f63ba93 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133301 Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
Sometimes we needs to produce these names in a NoSafepointScope, such as when generating a snapshot. Bug: dart-lang#40143 Change-Id: I0d66134c936313b16c38f8699b33a7c7bd443e75 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133153 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
Change-Id: I04414338a4072f4e2b45318df387313cdb979e6c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133161 Auto-Submit: Mike Fairhurst <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Paul Berry <[email protected]>
Change-Id: Ic38b274e09da497230473601a966950c478f3624 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133143 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Paul Berry <[email protected]>
Change-Id: I3e410861702c8f865c61942bc5d2d568b486035d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133144 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Paul Berry <[email protected]>
Change-Id: I89a1d35d6f8e4746adbb64316f69a5bb74efe381 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133145 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Paul Berry <[email protected]>
Change-Id: Idcc84dfc630781e621e9adc356efd5e5d704bda2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133146 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Paul Berry <[email protected]>
Change-Id: I4b0690f2d792430467f93be2aade6cd627b90016 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133162 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Paul Berry <[email protected]>
Change-Id: I19e20460154e0c05f0e115cae6cd79c36b8fb4b6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133163 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Paul Berry <[email protected]>
This was never supported by the grammar but unfortunately allowed by both the analyzer and the CFE. Change-Id: Id669c934fe08eda41973d6d2cef8340da2e7d72c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133591 Commit-Queue: Johnni Winther <[email protected]> Reviewed-by: Paul Berry <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Jens Johansen <[email protected]>
We were printing groups of builder names, not configurations Change-Id: Ia9a6791fbd25939f71a1aa227bc288197c838bd6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133991 Reviewed-by: Martin Kustermann <[email protected]>
Change-Id: Ic858a010f77a05c47430ce13d2bd7ef80535a538 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133990 Commit-Queue: Martin Kustermann <[email protected]> Auto-Submit: Martin Kustermann <[email protected]> Reviewed-by: Clement Skau <[email protected]>
If generated code refers to a constant object (which are old and canonical), a pointer to it will be embedded in the instruction stream on ia32. If we now reload and morph this constant object and allocate the morph'ed copy in new space, the become operation will make RX writable and the slot in the instruction stream gets updated to point to a new space object and the code gets added to the remembered set. The next scavenge operation will scan the remembered set as roots, see the poitner to a new object, move the object and updates the pointer in the instruction stream. => We hit a SEGV trying to write the RX memory We can avoid this problem by ensuring to morph old+canonical instances always into old space on ia32. Change-Id: Id63eb6ee1735bbb661dbeceb1e8d0c6ac92225ae Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133228 Auto-Submit: Martin Kustermann <[email protected]> Commit-Queue: Martin Kustermann <[email protected]> Reviewed-by: Ryan Macnak <[email protected]>
Infer other types as kPipe which is sync with Win platform. Bug: dart-lang#40354 Change-Id: I8bf40a143573685833a689ff2c724a421b308234 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133623 Reviewed-by: Zach Anderson <[email protected]> Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Zichang Guo <[email protected]>
This is a breaking change. Request: dart-lang#33501 HttpHeaders use lowercase by default for all headers, since it is supposed to be case insensitive. Some servers incorrectly treat case as significant, however, and expect headers with capitalization or in uppercase. The current implementation forces headers to be lower cases when adding values. Users cannot even manually modify the headers. This change removes this restriction here so that users can modify the headers to whatever form they want. The new behavior is backwards compatible except if class was implemented. All headers inside http.dart are written as lower cases, adding values to HttpHeaders is still receiving lower cases input. The other cl (https://dart-review.googlesource.com/c/http_multi_server/+/121411) migrates multi_headers.dart to be compatible with this change. Bug: dart-lang#33501 Change-Id: I6f7f2ef907b229773c283140c07f2de4cd500981 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119100 Commit-Queue: Zichang Guo <[email protected]> Reviewed-by: Lasse R.H. Nielsen <[email protected]>
The fix for empty_catch should not remove the catch clause if doing so would leave the try statement invalid. It could remove the whole try statement in such a case, but it isn't clear that that's a good solution in general. This at least patches the issue until we can decide whether additional work should be done. Change-Id: I7c5190faba9fd5632c04708007bc65bb18d3db6d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134087 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
Change-Id: Ic21556e8118a5b5d3b4a06ed6d3a7002f606f2ac Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134084 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
Change-Id: I9b06753cf552c9f50ea2abd7f3fa5ba9adecb526 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134085 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
Change-Id: Ia365fb43c6efc12c78a82841bcecffceefb501f3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134086 Reviewed-by: Paul Berry <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
We now test bounds for mutual subtyping rather than structural equality up to renaming of bound type variables and equating all top types. Change-Id: I7dd23a3211a1631e463ea90c3173f3deae46ca23 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134042 Commit-Queue: Mayank Patke <[email protected]> Reviewed-by: Sigmund Cherem <[email protected]>
The non-nnbd code doesn't have this extra `if`. It appears that this conditional was added during the migration but it is accidentally hiding the update to the _state. This change restores the algorithm to how it was before the migration and fixes lib_2/convert/base64_test/none Change-Id: I72dd2e870056bb55158bbd053d8a3c8825a1d144 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134090 Reviewed-by: Mark Zhou <[email protected]> Commit-Queue: Sigmund Cherem <[email protected]>
Specifically, we replace types of covariant parameters with `Object?` or `Object` and use subtype check. Then we check types of covariant formal parameters and corresponding overridden formal parameters. It looks that NNBD related changes that are coming now require such more precise following to the specification rules. Change-Id: Idfa4e3a118050a1be79acce8c708b3aac07b5051 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134043 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
Change-Id: I31eba9b4ced051a1067945fd68e60a09b1fa6ed7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133100 Reviewed-by: Alexander Markov <[email protected]> Reviewed-by: Jens Johansen <[email protected]> Commit-Queue: Johnni Winther <[email protected]>
Revert the changes made to DevCompilerTarget that allowed for optionally excluding libraries when building the null safe SDK. Fixes: dart-lang#39698 Change-Id: I0ae3160e17ca60b7a078a905ea12c8538d2aa045 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134081 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>
Change-Id: I42705320aabcdfecc12098f40ca16a2c623a1033 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134091 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Mayank Patke <[email protected]>
This is a potential workaround for: https://bugs.webkit.org/show_bug.cgi?id=199866 until a proper fix lands in Safari. See: dart-lang#40380 Change-Id: I66f5aefefcc6c8f12fd3b747fcee587fc16d437d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133542 Commit-Queue: Vijay Menon <[email protected]> Reviewed-by: Sigmund Cherem <[email protected]>
This makes the script properly produce an error message when it detects a mismatch on windows (there `diff` is not available.) Change-Id: Ibefe8c69023b42e8710e744f88257ff967d34bd2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134094 Reviewed-by: Vijay Menon <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]> Commit-Queue: Sigmund Cherem <[email protected]>
…e constructors (which can be shaken by TFA) This fixes debug assertions in AOT. Change-Id: Ib688164498ad98d2b7bb4ce574cf6859922df3a4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133999 Reviewed-by: Alexander Aprelev <[email protected]> Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
…rithm with an initial example implementation of RHSOfAsExpression Change-Id: Icaf3e80cb4d634f5871d576d3344210d631641c7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134092 Commit-Queue: Jaime Wren <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
Change-Id: Iaf1cd9f6833554a622ea8c97a7fefb7e09a9cd51 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134089 Reviewed-by: Sigmund Cherem <[email protected]>
…uts are always unboxed values and dont need to be checked) Change-Id: I9f5cd0d1dcbc2164b74783cc7ba12e56c0d7a685 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133998 Reviewed-by: Alexander Markov <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
…g#40115 Change-Id: I83b1db7c95ea0edb8a8d3af0f125219659c6df1d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134080 Commit-Queue: Samuel Rawlins <[email protected]> Reviewed-by: Paul Berry <[email protected]>
Change-Id: Ib4edee4d247bc9bb525d63bc527cecebe4e4a5ee Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134100 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Janice Collins <[email protected]>
This reverts commit b2b7337. Reason for revert: flutter build broke!! Original change's description: > [dart:io] Stop forcing lower case on HttpHeaders > > This is a breaking change. Request: dart-lang#33501 > > HttpHeaders use lowercase by default for all headers, since it is supposed to be case insensitive. Some servers incorrectly treat case as significant, however, and expect headers with capitalization or in uppercase. The current implementation forces headers to be lower cases when adding values. Users cannot even manually modify the headers. > > This change removes this restriction here so that users can modify the headers to whatever form they want. The new behavior is backwards compatible except if class was implemented. All headers inside http.dart are written as lower cases, adding values to HttpHeaders is still receiving lower cases input. > > The other cl (https://dart-review.googlesource.com/c/http_multi_server/+/121411) migrates multi_headers.dart to be compatible with this change. > > Bug: dart-lang#33501 > Change-Id: I6f7f2ef907b229773c283140c07f2de4cd500981 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119100 > Commit-Queue: Zichang Guo <[email protected]> > Reviewed-by: Lasse R.H. Nielsen <[email protected]> [email protected],[email protected],[email protected],[email protected] Change-Id: I4d4299393ad6549b250053df8823e726855e2baf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dart-lang#33501 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134102 Reviewed-by: Zichang Guo <[email protected]> Commit-Queue: Zichang Guo <[email protected]>
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
39 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #40429 for the definition of
@Unsafe. This will be used to create a lint (or do checks in the core analyzer).