Skip to content

[Analyzer] Cause CompileTimeError in analyzer when use 'Function' as a type: #45735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lfkdsk
Copy link
Contributor

@lfkdsk lfkdsk commented Apr 17, 2021

resolve #45704

  1. cause CompileTimeErrorCode.FUNCTION_CLASS_DECLARATION when declare class named 'Function'.
  2. cause CompileTimeErrorCode.FUNCTION_MIXIN_DECLARATION when declare mixin named 'Function'.
  3. cause CompileTimeErrorCode.FUNCTION_EXTENSION_DECLARATION when declare extension named 'Function'.
  4. cause CompileTimeErrorCode.FUNCTION_AS_TYPE_PARAMETER when type parameters contain parma named 'Function'.

@google-cla
Copy link

google-cla bot commented Apr 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 17, 2021
@lfkdsk lfkdsk force-pushed the feature-add-function-use-as-type-in-analyzer branch from 92c8c9f to 6725834 Compare April 17, 2021 14:44
@google-cla
Copy link

google-cla bot commented Apr 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lfkdsk lfkdsk changed the title Cause CompileTimeError in analyzer when use 'Function' as a type: [Analyzer] Cause CompileTimeError in analyzer when use 'Function' as a type: Apr 17, 2021
1. cause CompileTimeErrorCode.FUNCTION_CLASS_DECLARATION when declare class named 'Function'.
2. cause CompileTimeErrorCode.FUNCTION_MIXIN_DECLARATION when declare mixin named 'Function'.
3. cause CompileTimeErrorCode.FUNCTION_EXTENSION_DECLARATION when declare extension named 'Function'.
4. cause CompileTimeErrorCode.FUNCTION_AS_TYPE_PARAMETER when type parameters contain parma named 'Function'.
@lfkdsk lfkdsk force-pushed the feature-add-function-use-as-type-in-analyzer branch from 6725834 to 28e6468 Compare April 17, 2021 14:47
@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 17, 2021
@lfkdsk
Copy link
Contributor Author

lfkdsk commented Apr 17, 2021

@googlebot I fixed it.

@mraleph
Copy link
Member

mraleph commented Jun 10, 2021

For now I assume this is stale. Let me know if it is not.

@mraleph mraleph closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[analyzer] Function is a built-in identifier, but no error is emitted when it is used to name a type
2 participants