Skip to content

[analyzer] Function is a built-in identifier, but no error is emitted when it is used to name a type #45704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eernstg opened this issue Apr 14, 2021 · 6 comments
Closed

[analyzer] Function is a built-in identifier, but no error is emitted when it is used to name a type #45704

eernstg opened this issue Apr 14, 2021 · 6 comments
Labels
dart-model-analyzer-spec Issues with the analyzer's implementation of the language spec legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on

Comments

@eernstg
Copy link
Member

eernstg commented Apr 14, 2021

This is the analyzer specific issue for #45703, which has the details.
@eernstg eernstg added legacy-area-analyzer Use area-devexp instead. dart-model-analyzer-spec Issues with the analyzer's implementation of the language spec labels Apr 14, 2021
@lfkdsk lfkdsk mentioned this issue Apr 17, 2021
Closed
@lfkdsk
Copy link
Contributor

lfkdsk commented Apr 17, 2021

Hi @eernstg , I try to fix this with #45735

@scheglov scheglov added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Apr 19, 2021
@eernstg
Copy link
Member Author

eernstg commented Apr 19, 2021

Thanks, @lfkdsk! I suspect that the change would need to be made at a different level (where the treatment of built-in identifiers in general is handled), but @scheglov knows a lot more about that than I do. ;-)

@jcollins-g jcollins-g added this to the June release (stable) milestone May 13, 2021
@jcollins-g jcollins-g added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels May 13, 2021
@scheglov
Copy link
Contributor

I started this in https://dart-review.googlesource.com/c/sdk/+/200080, but it seems that there are more changes to CFE than I can do on my own.

@devoncarew
Copy link
Member

I started this in https://dart-review.googlesource.com/c/sdk/+/200080, but it seems that there are more changes to CFE than I can do on my own.

@scheglov - would it be good to have input / assistance from the CFE team for this? cc @johnniwinther

@johnniwinther
Copy link
Member

@jensjoha Could you take a look at the CL https://dart-review.googlesource.com/c/sdk/+/200080 from @scheglov ?

@devoncarew devoncarew removed this from the August release (beta) milestone Jul 20, 2021
copybara-service bot pushed a commit that referenced this issue Jun 28, 2022
@jensjoha
[parser][CFE][analyzer] Function is builtIn keyword
25dcfca 
This CL makes `Function` a builtIn keyword instead of a `pseudo` keyword.

See also (and fixes):
#45703
#45704
#45705
#49197

This undoes https://dart-review.googlesource.com/c/sdk/+/195761

This is ~a merge of https://dart-review.googlesource.com/c/sdk/+/195906
and https://dart-review.googlesource.com/c/sdk/+/200080

Change-Id: I8bfee6976d43819fa355de99b3b2429eb67a7cdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249484
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
@jensjoha
Copy link
Contributor

This should be fixed with 25dcfca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dart-model-analyzer-spec Issues with the analyzer's implementation of the language spec legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Analyzer] Cause CompileTimeError in analyzer when use 'Function' as a type: lfkdsk/sdk
7 participants
@scheglov @devoncarew @eernstg @lfkdsk @johnniwinther @jcollins-g @jensjoha