-
Notifications
You must be signed in to change notification settings - Fork 218
Fix fuzzy arrow warnings since they will become errors before too long. #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -272,7 +272,7 @@ class BrowserManager { | |||
} | |||
|
|||
/// The callback for handling messages received from the host page. | |||
void _onMessage(Map message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this. Is it possible to fix the place where this is used rather than loosen the argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer this as well. I'd like to avoid dynamic calls, even though in practice --no-implicit-dynamic
isn't really in shape to be enabled yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to fix the place where this is used rather than loosen the argument?
Done, though it feels a little silly in this case. _onMessage
is only called by that one place and Map
isn't super precise either.
@@ -272,7 +272,7 @@ class BrowserManager { | |||
} | |||
|
|||
/// The callback for handling messages received from the host page. | |||
void _onMessage(Map message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer this as well. I'd like to avoid dynamic calls, even though in practice --no-implicit-dynamic
isn't really in shape to be enabled yet.
Context: dart-lang/sdk#29630