Skip to content

Fix fuzzy arrow warnings since they will become errors before too long. #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/runner/browser/browser_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ class BrowserManager {
}));

_environment = _loadBrowserEnvironment();
_channel.stream.listen(_onMessage, onDone: close);
_channel.stream.listen((message) => _onMessage(message), onDone: close);
}

/// Loads [_BrowserEnvironment].
Expand Down
3 changes: 2 additions & 1 deletion lib/src/runner/configuration/load.dart
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@ class _ConfigurationLoader {

var paths = _getList("paths", (pathNode) {
_validate(pathNode, "Paths must be strings.", (value) => value is String);
_validate(pathNode, "Paths must be relative.", p.url.isRelative);
_validate(pathNode, "Paths must be relative.",
(value) => p.url.isRelative(value));

return _parseNode(pathNode, "path", p.fromUri);
});
Expand Down
1 change: 0 additions & 1 deletion lib/src/runner/loader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import '../backend/group.dart';
import '../backend/invoker.dart';
import '../backend/test_platform.dart';
import '../util/io.dart';
import '../utils.dart';
import 'browser/platform.dart';
import 'configuration.dart';
import 'configuration/suite.dart';
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test
version: 0.12.27
version: 0.12.27+1
author: Dart Team <[email protected]>
description: A library for writing dart unit tests.
homepage: https://github.com/dart-lang/test
Expand Down
2 changes: 0 additions & 2 deletions test/frontend/add_tear_down_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import 'dart:async';
import 'package:async/async.dart';
import 'package:test/test.dart';

import 'package:test/src/backend/declarer.dart';

import '../utils.dart';

void main() {
Expand Down