Support disabling the launch of DevTools through keybinding (#1269)

* Support disabling the launch of DevTools through keybinding

* test

* review fixes

Author: grouma

dwds/CHANGELOG.md

@@ -12,6 +12,7 @@
 - Depend on `package:vm_service` version `6.1.0+1`.
 - Update the `keepAlive` configs to prevent accidental reuse of a connection after stopping
   a debug session.
+- Support disabling the launching of Dart DevTools through `Alt + d` with `enableDevtoolsLaunch`.
 
 **Breaking changes:**
 - `LoadStrategy`s now require a `moduleInfoForEntrypoint`.

dwds/lib/dwds.dart

@@ -103,14 +103,17 @@ class Dwds {
     bool useSseForDebugBackend,
     bool serveDevTools,
     UrlEncoder urlEncoder,
-    bool spawnDds = true,
+    bool spawnDds,
+    bool enableDevtoolsLaunch,
   }) async {
     hostname ??= 'localhost';
     enableDebugging ??= true;
     enableDebugExtension ??= false;
     useSseForDebugProxy ??= true;
     useSseForDebugBackend ??= true;
     serveDevTools ??= true;
+    enableDevtoolsLaunch ??= true;
+    spawnDds ??= true;
     globalLoadStrategy = loadStrategy;
 
     DevTools devTools;
@@ -146,6 +149,7 @@ class Dwds {
     var injected = DwdsInjector(
       loadStrategy,
       extensionUri: extensionUri,
+      enableDevtoolsLaunch: enableDevtoolsLaunch,
     );
 
     var devHandler = DevHandler(

dwds/lib/src/handlers/injector.dart

@@ -34,11 +34,14 @@ class DwdsInjector {
   final String _extensionUri;
   final _devHandlerPaths = StreamController<String>();
   final _logger = Logger('DwdsInjector');
+  final bool _enableDevtoolsLaunch;
 
   DwdsInjector(
     this._loadStrategy, {
     String extensionUri,
-  }) : _extensionUri = extensionUri;
+    bool enableDevtoolsLaunch,
+  })  : _extensionUri = extensionUri,
+        _enableDevtoolsLaunch = enableDevtoolsLaunch;
 
   /// Returns the embedded dev handler paths.
   ///
@@ -93,6 +96,7 @@ class DwdsInjector {
                 entrypoint,
                 _extensionUri,
                 _loadStrategy,
+                _enableDevtoolsLaunch,
               );
               body += await _loadStrategy.bootstrapFor(entrypoint);
               _logger.info('Injected debugging metadata for '
@@ -122,6 +126,7 @@ String _injectClientAndHoistMain(
   String entrypointPath,
   String extensionUri,
   LoadStrategy loadStrategy,
+  bool enableDevtoolsLaunch,
 ) {
   var bodyLines = body.split('\n');
   var extensionIndex =
@@ -140,6 +145,7 @@ String _injectClientAndHoistMain(
     entrypointPath,
     extensionUri,
     loadStrategy,
+    enableDevtoolsLaunch,
   );
   result += '''
   // Injected by dwds for debugging support.
@@ -172,13 +178,15 @@ String _injectedClientSnippet(
   String entrypointPath,
   String extensionUri,
   LoadStrategy loadStrategy,
+  bool enableDevtoolsLaunch,
 ) {
   var injectedBody = 'window.\$dartAppId = "$appId";\n'
       'window.\$dartReloadConfiguration = "${loadStrategy.reloadConfiguration}";\n'
       'window.\$dartModuleStrategy = "${loadStrategy.id}";\n'
       'window.\$loadModuleConfig = ${loadStrategy.loadModuleSnippet};\n'
       'window.\$dwdsVersion = "$packageVersion";\n'
       'window.\$dwdsDevHandlerPath = "$devHandlerPath";\n'
+      'window.\$dwdsEnableDevtoolsLaunch = $enableDevtoolsLaunch;\n'
       'window.\$dartEntrypointPath = "$entrypointPath";\n'
       '${loadStrategy.loadClientSnippet(_clientScript)}';
   if (extensionUri != null) {