Support disabling the launch of DevTools through keybinding #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Mar 11, 2021
| @@ -163,6 +163,12 @@ void main() { | |||
| expect(result.body.contains('dummy-load-client-snippet'), isTrue); | |||
| }); | |||
|
|
|||
| test('Injects dwds enable devtools launch configuraation', () async { | |||
There was a problem hiding this comment.
I loathe my mac keyboard....
jacob314
reviewed
Mar 11, 2021
dwds/lib/dwds.dart
Outdated
| @@ -104,13 +104,15 @@ class Dwds { | |||
| bool serveDevTools, | |||
| UrlEncoder urlEncoder, | |||
| bool spawnDds = true, | |||
There was a problem hiding this comment.
nit: why do some of these have default values here while others use ??=?
There was a problem hiding this comment.
Because I didn't add that :P I prefer the ??= pattern while this package isn't migrated to null safety. Fixed.
| launchDevToolsJs(); | ||
| } | ||
| }); | ||
| if (dwdsEnableDevtoolsLaunch) { |
There was a problem hiding this comment.
I wonder if this listener was interacting with any of the flutter keyboard support...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jonahwilliams
Related #1268 (comment)