Read debug symbols provided by DDC #1329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Jun 2, 2021
annagrin
changed the title
annagrin
force-pushed
the
annagrin/read_symbols_new
branch
from
cf5172c to
dfd0107
Compare
annagrin
changed the title
nshahan
reviewed
Jun 3, 2021
grouma
reviewed
Jun 3, 2021
grouma
reviewed
Jun 3, 2021
grouma
approved these changes
Jun 4, 2021
nshahan
approved these changes
Jun 7, 2021
annagrin
force-pushed
the
annagrin/read_symbols_new
branch
from
2ccffdb to
23a97fc
Compare
annagrin
force-pushed
the
annagrin/read_symbols_new
branch
from
679f4f5 to
e152d0d
Compare
|
Updated build_web_compilers now that dart-lang/build#3120 is published. |
added 10 commits
July 13, 2021 12:14
annagrin
force-pushed
the
annagrin/read_symbols_new
branch
from
60abfaf to
394e4d0
Compare
|
@grouma I updated min SDK and build_web_compilers constraints, could you please have another look? |
|
Closing this, as it is a few years old now and quite out of date. Feel free to reopen in case you still want to land it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first in a series of changes to support dwds translating JS objects to dart when displaying the objects to the user, for example, in variable inspection, watch, or expression evaluation windows.
The aim is to make the translation guess-free and reduce the number of calls to chrome.
The symbols are currently stored by DDC in https://dart-review.googlesource.com/c/sdk/+/200528.
Related:
dart-lang/sdk#40273
Towards:
#982
Update: Converting to draft for now - will come back to it after reliability and IPL changes are shipped to flutter.