Skip to content

Read debug symbols provided by DDC #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
## 12.0.0-dev

- Add code for loading symbols generated by DDC, if
`enableDebugSymbols` is set to `true` in `dwds.start`.
To be used by variable inspection, not implemented yet.
- Require at least `build_web_compilers` version `3.1.0`.
- Update min sdk constraint to `>=2.14.0-216.0.dev`.

**Breaking changes:**
- Add `enableDebugSymbols` parameter `Dwds.start`, false by default.
- Add `symbolsContents` method to `AssetReader`.

## 11.1.2-dev

- Return empty library from `ChromeProxyService.getObject` for
Expand Down
6 changes: 5 additions & 1 deletion dwds/lib/dwds.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import 'src/services/expression_compiler.dart';

export 'src/connections/app_connection.dart' show AppConnection;
export 'src/connections/debug_connection.dart' show DebugConnection;
export 'src/debugging/metadata/module_metadata.dart' show ModuleInfo;
export 'src/debugging/metadata/provider.dart'
show MetadataProvider, AbsoluteImportUriException;
export 'src/events.dart' show DwdsEvent;
Expand All @@ -46,7 +47,7 @@ export 'src/readers/proxy_server_asset_reader.dart' show ProxyServerAssetReader;
export 'src/servers/devtools.dart';
export 'src/services/chrome_proxy_service.dart' show ChromeDebugException;
export 'src/services/expression_compiler.dart'
show ExpressionCompilationResult, ExpressionCompiler, ModuleInfo;
show ExpressionCompilationResult, ExpressionCompiler;
export 'src/services/expression_compiler_service.dart'
show ExpressionCompilerService;

Expand Down Expand Up @@ -100,6 +101,7 @@ class Dwds {
// TODO(annagrin): make expressionCompiler argument required
// [issue 881](https://github.com/dart-lang/webdev/issues/881)
ExpressionCompiler expressionCompiler,
bool enableDebugSymbols,
bool enableDebugExtension,
String hostname,
bool useSseForDebugProxy,
Expand All @@ -119,6 +121,7 @@ class Dwds {
enableDevtoolsLaunch ??= true;
spawnDds ??= true;
globalLoadStrategy = loadStrategy;
enableDebugSymbols ??= false;

DevTools devTools;
String extensionUri;
Expand Down Expand Up @@ -171,6 +174,7 @@ class Dwds {
useSseForInjectedClient,
serveDevTools,
expressionCompiler,
enableDebugSymbols,
injected,
spawnDds,
);
Expand Down
11 changes: 11 additions & 0 deletions dwds/lib/src/debugging/metadata/module_metadata.dart
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,14 @@ class ModuleMetadata {
};
}
}

class ModuleInfo {
final String fullDillPath;
final String summaryPath;
final String symbolsPath;

ModuleInfo(this.fullDillPath, this.summaryPath, this.symbolsPath);

@override
String toString() => '{ $fullDillPath, $summaryPath, $symbolsPath }';
}
Loading