Skip to content

Adds an IDE query parameter to the Dart DevTools URL #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

elliette
Copy link
Contributor

This query parameter is used in Dart DevTools to track how how it was launched. This should give us metrics on the number of users launching Dart DevTools from the Dart Debug Extension.

@elliette elliette requested a review from annagrin February 22, 2022 21:42
@annagrin
Copy link
Contributor

annagrin commented Feb 22, 2022

Thanks Elliott! Is it possible to add a test for this functionality as well?

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add a test, if it is possible!

@annagrin
Copy link
Contributor

Thanks, found the tests!

@annagrin annagrin self-requested a review February 22, 2022 23:46
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 9a45590 into dart-lang:master Feb 23, 2022
@elliette elliette deleted the embed-param2 branch May 4, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants