[MV3 Debug Extension] Extension sets the ide query parameter for the DevTools URI
#1943
Conversation
elliette
changed the title
ide query parameter for the DevTools URI
| bool? get uriOnly; | ||
|
|
There was a problem hiding this comment.
Just curious - do they have to be nullable, or can we made them non-nulllable and false by default?
There was a problem hiding this comment.
I think they make sense to be nullable, since they aren't applicable to non-extension requests. This is the same as tabUrl and contextId (above) which are also null. Added a comment.
| // parameter to the DevTools URI: | ||
| final devToolsUri = (devToolsRequest.isMv3Extension ?? false) | ||
| ? _constructDevToolsUri(encodedUri) | ||
| : _constructDevToolsUri( |
There was a problem hiding this comment.
Can the original extension also add the IDE query parameter, so we don't have to split? Or is it too much change?
There was a problem hiding this comment.
We would have to do a new release of the old extension, and still handle transition period while it is being released (so there would still be a split). I've added a TODO to remove the old code once the MV3 extension is released.
In the MV2 extension, DWDS could tell whether a
DevToolsRequestwas for embedding in Chrome DevTools (uriOnly=true). It would then set theidequery parameter toChromeDevToolsif embedded, orDebugExtensionif not. See #1522In the MV3 extension, all
DevToolsRequestshaveuriOnly=true. Therefore, we handle adding theidequery parameter from the extension and not from DWDS.