This repository was archived by the owner on May 17, 2024. It is now read-only.
Simplify by replacing the self-made WeakCache with the builtin WeakValueDict #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtoonstra
approved these changes
Sep 22, 2023
nolar
force-pushed
the
simplify-weakcache
branch
2 times, most recently
from
e20e94c to
e5ef175
Compare
nolar
force-pushed
the
simplify-weakcache
branch
from
e5ef175 to
e9a36de
Compare
cfernhout
approved these changes
Sep 22, 2023
cfernhout
reviewed
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of the series of simplifications, basically as a preliminary warmup/cleanup: remove unnecessary entities & abstractions.