Skip to content

Remove @types/long dependency #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ramikg
Copy link
Contributor

@ramikg ramikg commented Nov 30, 2023

I've removed the @types/long dependency, in order to avoid the following deprecation warning:

This is a stub types definition. long provides its own type definitions, so you do not need this installed.

@Graphmaxer
Copy link

Graphmaxer commented Mar 4, 2024

Interested into this change since it break our builds

error TS2688: Cannot find type definition file for 'long'.
   The file is in the program because:
   Entry point for implicit type library 'long'

Currently, we fix it with overrides in the package.json

  "overrides": {
    "@types/long": "4.0.2"
  },

@Graphmaxer
Copy link

I created an issue in the Jira https://datastax-oss.atlassian.net/browse/NODEJS-671 Maybe it will help :/

Copy link

@SiyaoIsTraveling SiyaoIsTraveling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!
The package long used to be pure javascript without type declaration files (.d.ts files). Therefore, in the past we needed @types/long, a community contributed package of type declaration files for long.
Now long is shipped with type declaration files, see the index.d.ts here. Therefore, we don't need @types/long anymore.
Please merge as long as our CI got green @absurdfarce .

@absurdfarce
Copy link
Collaborator

Thanks for the investigation @SiyaoIsTraveling; your explanation makes perfect sense to me!

I've kicked off a Jenkins build for this PR; assuming there's no regression there (and I really don't expect one) we should be good to get this guy merged.

@absurdfarce
Copy link
Collaborator

Bah, missed this in my last comment... big thanks to @ramikg as well for raising (and fixing!) the issue in the first place!

@absurdfarce
Copy link
Collaborator

Jenkins run was indeed green, calling this good

@absurdfarce absurdfarce merged commit eb586f8 into datastax:master Dec 24, 2024
3 checks passed
@ramikg
Copy link
Contributor Author

ramikg commented Dec 24, 2024

Thank you!

@ramikg ramikg deleted the hotfix/remove-types-long-dependency branch December 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants