-
Notifications
You must be signed in to change notification settings - Fork 207
Remove @types/long
dependency
#417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @types/long
dependency
#417
Conversation
Interested into this change since it break our builds
Currently, we fix it with overrides in the "overrides": {
"@types/long": "4.0.2"
}, |
I created an issue in the Jira https://datastax-oss.atlassian.net/browse/NODEJS-671 Maybe it will help :/ |
6f21377
to
9217739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
The package long
used to be pure javascript without type declaration files (.d.ts
files). Therefore, in the past we needed @types/long
, a community contributed package of type declaration files for long
.
Now long
is shipped with type declaration files, see the index.d.ts
here. Therefore, we don't need @types/long
anymore.
Please merge as long as our CI got green @absurdfarce .
Thanks for the investigation @SiyaoIsTraveling; your explanation makes perfect sense to me! I've kicked off a Jenkins build for this PR; assuming there's no regression there (and I really don't expect one) we should be good to get this guy merged. |
Bah, missed this in my last comment... big thanks to @ramikg as well for raising (and fixing!) the issue in the first place! |
Jenkins run was indeed green, calling this good |
Thank you! |
I've removed the
@types/long
dependency, in order to avoid the following deprecation warning: