-
Notifications
You must be signed in to change notification settings - Fork 207
Replace deprecated usages of util.isDate
& util.isString
#429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated usages of util.isDate
& util.isString
#429
Conversation
Yep, I'm having the same issue on Node.js v22
Using flag
This PR seems to be a good fix for the deprecation warning 👍 |
Thank you. Unfortunately, I'm not sure that this repository is being maintained. |
Hi @ramikg, thank you for your contributions to this project! Yes this project is being maintained :) |
Glad to hear that. Also, I signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM! util.isDate
and util.isString
are deprecated and this PR replaced them by the practices suggested by the official doc. Please merge as long as it passes all the tests @absurdfarce .
Looks good to me as well; thanks for the PR @ramikg! Agreed that this seems quite sensible. I've kicked off a Jenkins run for this change, so as long as we don't have any giant regressions or anything we should be fine to get this merged. |
Jenkins run was indeed green, calling this good |
Thank you! |
The functions
util.isDate
&util.isString
have been deprecated for a few years, and have been removed in Node.js 23.In order for nodejs-driver to be supported on recent Node.js versions, I've replaced their usages with the ones recommended in the docs.