Skip to content

chore(deps): bump org.apache.maven.reporting:maven-reporting-api from 3.1.1 to 4.0.0 #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 25, 2024

Bumps org.apache.maven.reporting:maven-reporting-api from 3.1.1 to 4.0.0.

Commits
  • ad877cd [maven-release-plugin] prepare release maven-reporting-api-4.0.0
  • e0809ea [MSHARED-1427] Upgrade to Doxia 2.0.0
  • 515ccc9 Fix SCM tag
  • 2a556b3 Bump org.apache.maven.shared:maven-shared-components from 42 to 43
  • 5299cdb use new Reproducible Central badge endpoint
  • 300d95a [maven-release-plugin] prepare for next development iteration
  • be411c9 [maven-release-plugin] prepare release maven-reporting-api-4.0.0-M12
  • cda5232 [MSHARED-1399] Upgrade to Doxia 2.0.0-M12
  • b5bf68e Bump maven-gh-actions-shared to v4
  • 7c0a727 [MSHARED-1396] Upgrade to Doxia 2.0.0-M11
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies java Pull requests that update Java code labels Nov 25, 2024
@slandelle slandelle force-pushed the dependabot/maven/org.apache.maven.reporting-maven-reporting-api-4.0.0 branch from 093e404 to 3dbf418 Compare March 24, 2025 10:46
Bumps [org.apache.maven.reporting:maven-reporting-api](https://github.com/apache/maven-reporting-api) from 3.1.1 to 4.0.0.
- [Commits](apache/maven-reporting-api@maven-reporting-api-3.1.1...maven-reporting-api-4.0.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.reporting:maven-reporting-api
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@slandelle slandelle force-pushed the dependabot/maven/org.apache.maven.reporting-maven-reporting-api-4.0.0 branch from 3dbf418 to c51640d Compare March 24, 2025 14:27
@davidB
Copy link
Owner

davidB commented Mar 24, 2025

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 24, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@slandelle
Copy link
Collaborator

@davidB Yeah, I've already rebased it manually.
#806 and #822 can't pass CI individually because reporting-api and doxia need to be compatible with each other. Except I don't know if they can be upgraded altogether while retaining compatibility with maven 3. I'll investigate, unless someone is faster than me.

@jozic
Copy link
Contributor

jozic commented Mar 25, 2025

@slandelle they can be upgraded and stay compatible with maven 3. I did that with maven scoverage plugin recently

scoverage/scoverage-maven-plugin#334

@slandelle slandelle merged commit 0ea7d3b into master Mar 25, 2025
1 of 3 checks passed
@slandelle slandelle deleted the dependabot/maven/org.apache.maven.reporting-maven-reporting-api-4.0.0 branch March 25, 2025 07:03
@slandelle
Copy link
Collaborator

Thanks @jozic !

@slandelle
Copy link
Collaborator

slandelle commented Mar 25, 2025

@jozic So actually, it seems that we can't just upgrade these dependencies as-is.

I don't know if the ScalaDocMojo mojo does things right or not, but it extends MavenReport from maven-reporting-api.
If we just upgrade our maven-reporting-api and doxia-sink-api dependencies, we end up with a linkage error at runtime with the version that maven 3.9.9 depends on by default.

You don't see this linkage error in your tests on scoverage-maven-plugin because you're adding the maven-site-plugin:3.21.0 to your build, which seems to somehow force a maven-reporting-api upgrade.

I don't know the solution at this point, but generating scaladoc should work out-of-the-box without adding anything else to the build than this plugin.

Pinging @froque and @gnodet because you guys seem to be familiar with the maven 4 upgrade path.

@slandelle
Copy link
Collaborator

I've pushed the work in progress in this PR: #843.
I've upgraded maven-site-plugin only in the tests that are supposed to use it and as you can see, they are successful.
But all the tests that don't configure it and are just supposed to generate the scaladoc fail with a linkage error.

@jozic
Copy link
Contributor

jozic commented Mar 26, 2025

@slandelle I see you found the fix in #843, right?

@slandelle
Copy link
Collaborator

@davidB did :)

@jozic
Copy link
Contributor

jozic commented Mar 26, 2025

Immensely grateful to both of you for keeping this running! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants