Chore doxia site upgrade #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [org.apache.maven.reporting:maven-reporting-api](https://github.com/apache/maven-reporting-api) from 3.1.1 to 4.0.0. - [Commits](apache/maven-reporting-api@maven-reporting-api-3.1.1...maven-reporting-api-4.0.0) --- updated-dependencies: - dependency-name: org.apache.maven.reporting:maven-reporting-api dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.apache.maven.doxia:doxia-sink-api](https://github.com/apache/maven-doxia) from 1.12.0 to 2.0.0. - [Release notes](https://github.com/apache/maven-doxia/releases) - [Commits](apache/maven-doxia@doxia-1.12.0...doxia-2.0.0) --- updated-dependencies: - dependency-name: org.apache.maven.doxia:doxia-sink-api dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
davidB
reviewed
Mar 25, 2025
Comment on lines
84
to
87
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-site-plugin</artifactId> | ||
| <version>3.12.1</version> | ||
| <version>3.21.0</version> | ||
| </plugin> |
There was a problem hiding this comment.
Why the groupId is removed on this test but not in other?
There was a problem hiding this comment.
Yeah, I might clean up everywhere, or not. I don't like verbosity, groupId is optional for plugins, with org.apache.maven.plugins but most people don't know this, including IntelliJ...
Else it's the same test as it/test_goal_site
slandelle
commented
Mar 25, 2025
| @@ -1 +1 @@ | |||
| invoker.goals=clean compile site -e | |||
| invoker.goals=clean compile scala:doc -e | |||
There was a problem hiding this comment.
Ahhh, so that was the reason!
davidB
approved these changes
Mar 25, 2025
|
Thanks @davidB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.