Nova 5 Support #24
Open
Nova 5 Support #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* comment out unused imports in ActionDropdown and ActionSelector compo… * add nova repository to composer.json * add Tailwind CSS plugins and new dependencies to package.json * fix: update path to Nova Tailwind config in tailwind.config.js * style: refactor icon-action-toolbar styles for improved readability * style: refactor icon-action-toolbar styles for improved readability
* comment out unused imports in ActionDropdown and ActionSelector components * add nova repository to composer.json * add Tailwind CSS plugins and new dependencies to package.json * fix: update path to Nova Tailwind config in tailwind.config.js * style: refactor icon-action-toolbar styles for improved readability * style: refactor icon-action-toolbar styles for improved readability * style: uncomment imports in ActionDropdown and ActionSelector for clarity * add axios and vuex dependencies to package.json * feat: add Webpack alias for Nova resources and log build process * automatic build * style: uncomment imports in ActionDropdown and ActionSelector for clarity
* comment out unused imports in ActionDropdown and ActionSelector compo… * add nova repository to composer.json * add Tailwind CSS plugins and new dependencies to package.json * fix: update path to Nova Tailwind config in tailwind.config.js * style: refactor icon-action-toolbar styles for improved readability * style: refactor icon-action-toolbar styles for improved readability * style: uncomment imports in ActionDropdown and ActionSelector for cla… * add axios and vuex dependencies to package.json * feat: add Webpack alias for Nova resources and log build process * automatic build * Merge branch 'main' into bugfix/showIcons * style: uncomment imports in ActionDropdown and ActionSelector for cla… * style: uncomment imports in ActionDropdown and ActionSelector for cla… * style: uncomment imports in ActionDropdown and ActionSelector for cla…
* style: uncomment imports in ActionDropdown and ActionSelector for clarity * style: uncomment imports in ActionDropdown and ActionSelector for clarity * style: format console log for improved readability * feat: add findOccurrences function for object search capability * style: uncomment findOccurrences logging for clarity * style: replace findOccurrences logging with JSON.stringify for better output readability * feat: add trimObject function for safe object logging and prevent circular reference issues * feat: add trimObject function for safe object logging and prevent circular reference issues * feat: add vue-router integration and computed properties for route handling * feat: add vue-router integration and computed properties for route handling * feat: add vue-router integration and computed properties for route handling * feat: add vue-router integration and computed properties for route handling * refactor: comment out delete resource action in ActionDropdown and tool.js * feat: add trimObject function for object serialization and logging * feat: add trimObject function for object serialization and logging * refactor: uncomment delete resource action in ActionDropdown and tool.js * refactor: update logging to include Nova.store in ActionDropdown and tool.js * refactor: update logging to include Nova object and comment out delete resource action in ActionDropdown and tool.js * refactor: update logging to include Nova object and comment out delete resource action in ActionDropdown and tool.js * refactor: update resource ID logging to use Inertia and clean up unused code in ActionDropdown and tool.js * refactor: add Inertia.js dependency and enable usePage import in ActionDropdown * refactor: enhance logging to include Inertia page data in ActionDropdown and tool.js * refactor: add computed properties for resource mode checks in ActionDropdown and tool.js * refactor: update resource mode checks in ActionDropdown and tool.js to use URL patterns * refactor: enhance resource page checks in ActionDropdown and tool.js to support UUID patterns * refactor: streamline index and detail page checks in ActionDropdown and tool.js * refactor: add console logging for detail page checks in ActionDropdown and tool.js * refactor: add console logging for detail page checks in ActionDropdown and tool.js * refactor: update console logging and detail page checks in ActionDropdown and tool.js * refactor: update detail page check logic in IconActionToolbar and ActionDropdown * refactor: add console logging for resource fields in ActionDropdown and tool.js * refactor: add console logging for resource fields in ActionDropdown and tool.js * refactor: remove redundant props variable in ActionDropdown and tool.js * refactor: enhance console logging and update detail page check logic in ActionDropdown and tool.js * refactor: remove unused variables and console logs in ActionDropdown and tool.js * refactor: update delete resource logic to handle null viaResourceId in ActionDropdown and tool.js * refactor: add detailed console logging for resource and props in ActionDropdown and tool.js * refactor: improve console logging and update delete resource logic in ActionDropdown and tool.js * refactor: update console logging and modify delete resource logic to check for undefined viaResourceId in ActionDropdown and tool.js * refactor: remove excessive console logging in ActionDropdown and tool.js
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the issue description:
#21
We discovered that the plugin crashes under Nova 5 due to changes in Nova’s internal object structure. Specifically, the reference to Nova.$router.page.component — which the plugin used to determine whether rendering was on a detail view or an index page — is no longer available.
For an example of the [ previous implementation ], please see this reference.
We addressed the issue by implementing a basic solution that distinguishes between index and detail views by analyzing the current URL. Although this approach works for our setup, it may not be ideal. As I mentioned earlier, I’m not a JS/Vue expert, so I welcome any suggestions for improvement.