Repository navigation
Fixed the issue that universal checkpoint cannot be loaded for stage3 when world size expansion. - #7599
Merged
sfc-gh-truwase merged 5 commits intoOct 1, 2025
Conversation
… when world size expansion
zhengchenyu
marked this pull request as draft
September 28, 2025 06:49
zhengchenyu
marked this pull request as ready for review
September 28, 2025 12:16
zhengchenyu
marked this pull request as draft
September 29, 2025 02:52
5 tasks
zhengchenyu
marked this pull request as ready for review
September 29, 2025 10:25
sfc-gh-truwase
enabled auto-merge (squash)
October 1, 2025 10:57
sfc-gh-truwase
approved these changes
Oct 1, 2025
delock
pushed a commit
that referenced
this pull request
Oct 3, 2025
… when world size expansion. (#7599) When the world size expands from 2 to 4, then convert to universal checkpoint, and load from universal checkpoint. The new rank, for example, rank3 will load model file `zero_pp_rank_3_mp_rank_00_model_states.pt`. But this file was not produced during the last execution. For stage3, just load the first file, that is `zero_pp_rank_0_mp_rank_00_model_states`. The existing unit test TestZeROUniversalCheckpointDP::test_dp_world_size_2to4 can verify this problem. --------- Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Signed-off-by: Guokai Ma <guokai.ma@gmail.com>
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
… when world size expansion. (deepspeedai#7599) When the world size expands from 2 to 4, then convert to universal checkpoint, and load from universal checkpoint. The new rank, for example, rank3 will load model file `zero_pp_rank_3_mp_rank_00_model_states.pt`. But this file was not produced during the last execution. For stage3, just load the first file, that is `zero_pp_rank_0_mp_rank_00_model_states`. The existing unit test TestZeROUniversalCheckpointDP::test_dp_world_size_2to4 can verify this problem. --------- Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the world size expands from 2 to 4, then convert to universal checkpoint, and load from universal checkpoint.
The new rank, for example, rank3 will load model file
zero_pp_rank_3_mp_rank_00_model_states.pt. But this file was not produced during the last execution.For stage3, just load the first file, that is
zero_pp_rank_0_mp_rank_00_model_states.The existing unit test TestZeROUniversalCheckpointDP::test_dp_world_size_2to4 can verify this problem.