Skip to content

Fixed the issue that universal checkpoint cannot be loaded for stage3 when world size expansion. #7599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-truwase merged 5 commits into from
Oct 1, 2025
Merged

Fixed the issue that universal checkpoint cannot be loaded for stage3 when world size expansion. #7599

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b29e29
Fixed the issue that universal checkpoint cannot be loaded for stage3…
zhengchenyu Sep 28, 2025
707a1d0
fix load checkpoint when disable univeral
zhengchenyu Sep 29, 2025
21f448c
Merge branch 'master' into fix.load.universal
sfc-gh-truwase Sep 30, 2025
97a0586
Merge branch 'master' into fix.load.universal
sfc-gh-truwase Oct 1, 2025
1129787
Merge branch 'master' into fix.load.universal
sfc-gh-truwase Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3011,15 +3011,20 @@ def _get_zero_ckpt_name(self, checkpoints_path, tag):
bf16_mode = self.bfloat16_enabled()
return self._get_rank_zero_ckpt_name(checkpoints_path, tag, mp_rank, pp_rank, bf16_mode)

def _get_ckpt_name(self, checkpoints_path, tag, mp_placeholder=None):
def _get_ckpt_name(self, checkpoints_path, tag, mp_placeholder=None, pp_placeholder=None):
if mp_placeholder is not None:
mp_rank_str = mp_placeholder
else:
mp_rank = 0 if self.mpu is None else self.mpu.get_model_parallel_rank()
mp_rank_str = f"{mp_rank:02d}"

if self.zero_optimization_partition_weights():
filename = "zero_pp_rank_{}".format(dist.get_rank(group=self.optimizer.dp_process_group))
if pp_placeholder is not None:
pp_rank = pp_placeholder
else:
pp_rank = dist.get_rank(group=self.optimizer.dp_process_group)

filename = "zero_pp_rank_{}".format(pp_rank)
ckpt_name = os.path.join(
checkpoints_path,
str(tag),
Expand Down Expand Up @@ -3054,15 +3059,15 @@ def _get_expert_ckpt_name(checkpoints_path, layer_id, expert_id, tag, mpu=None):

def _get_all_ckpt_names(self, checkpoints_path, tag):
# It is required that (checkpoints_path, tag) are consistent among all ranks.
ckpt_file_pattern = self._get_ckpt_name(checkpoints_path, tag, mp_placeholder="*")
ckpt_file_pattern = self._get_ckpt_name(checkpoints_path,
tag,
mp_placeholder="*",
Comment thread
sfc-gh-truwase marked this conversation as resolved.
Resolved
pp_placeholder="0" if self.load_universal_checkpoint() else None)
import glob

ckpt_files = glob.glob(ckpt_file_pattern)
ckpt_files.sort()
if self.load_universal_checkpoint():
return [ckpt_files[0]]
else:
return ckpt_files
return ckpt_files

def load_checkpoint(self,
load_dir,
Expand Down