feat: consolidate dendron configs #1295

hikchoi · 2021-09-06T11:57:26Z

feat: consolidate dendron configs

This PR consolidates and organizes all Dendron configurations.

Docs for config style guide: dendronhq/dendron-site#196
Docs for diff between as-is config and to-be config: TBD

for easier review, read in this order

Overview of changes below
Config convention docs PR: add convention guide for configs dendron-site#196
packages/common-all/src/types/configs/base.ts
everything in packages/common-all/src/types/configs/*, starting from packages/common-all/src/types/configs/dendronConfig.ts
everything in packages/common-all/src/constants/configs/*, starting form packages/common-all/src/constants/configs/dendronConfig.ts

Overview of changes

The new configuration is organized into the following namespaces:

global (DendronGlobalConfig)
- config entries that can affect both preview and publishing.
- all config entries here are also in the preview and publishing namespace.
- configurations set here will be overriden by a more specific config entry if it exists.
preview (DendronPreviewConfig)
- config entries that changes behavior of preview.
publishing (DendronPublishingConfig)
- config entries that changes behavior of publishing.
workspace (DendronWorkspaceConfig)
- config entries that changes behavior of the workspace.
commands (DendronCommandConfig)
- config entries that change behavior of Dendron commands.
dev (DendronDevConfig)
- beta feature flags.

Config type definitions

The type definition of these configurations can be found in their respective modules in packages/common-all/src/types/configs/ along with a function that generates the defaults of those configs.
Some top level namespaces are further divided in to smaller sub-namespaces so the configurations are logically nested into groups.
All namespaces are defined to be required with the exception of DendronDevConfig.

Constants

Each namespace also has a constant object that holds labels and descriptions about every possible configuration entries.
They will be used to generate the configuration UI dynamically.
These can be found in packages/common-all/src/constants/configs/
Every config entry that is not a namespace (i.e. a single config) will have a constant of type DendronConfigEntry<T>, where T is the type of the config value.

For example, for the config initialValue of the command InsertNote has a DendronConfigEntry<string> like so:

  {
    label: "Initial Value",
    desc: "Initial value that will be filled when prompted.",
  },

This is the type definition of DendronConfigEntry:
```
export type DendronConfigEntry<T> = {
  value?: T;
  label: string;
  desc: string;
};
```
- Note that value is defined to be optional, as some configs can have arbitrary values. In which case passing in the correct type T is meaningless, but is there for completeness' sake.
If a DendronConfigEntry have a selected number of possible values, the value is specified, and label and description is written to take account of the different behaviors respective values enable.

For example, the selection mode extract of Note lookup looks like this:

{
  value: LookupSelectionModeEnum.extract,
  label: "Extract Selection",
  desc: "Extract selection of active editor and use it as body of new note.",
},

Some configurations are duplicated in multiple namespaces, thus producing identical DendronConfigEntry in multiple places. Some configurations benefit from dynamically generated descriptions. To reduce repeated code, there are functions that generate DendronConfigEntry based on the value given.

For example, enabling mermaid syntax can happen in preview and publishing (as well as global). This is the function that generates the config entries.

export const ENABLE_MERMAID = (
  namespace: TopLevelDendronConfig
): DendronConfigEntry<boolean> => {
  return {
    label: `Enable Mermaid (${namespace})`,
    desc: `Enable the use of mermaid for rendering diagrams. (${namespace})`,
  };
};

// used elsewhere
{
  ...
  enableMermaid: ENABLE_MERMAID("preview"),
  ...
}

Like the type definition, the constants are nested into groups of namespaces.
In fact, the type signature of these constants is a mapped type that maps all the config type's keys into DendronConfigEntrys.
- This is called a DendronConfigEntryCollection.
- The benefit of this is that if you change the definition of any type in any namespace, you will get an error that you forgot to define the DendronConfigEntry of it if you omit it.

DendronConfigEntryCollection looks like this:

export type DendronConfigEntryCollection<T> = {
  [Property in keyof T]-?: // the -? tells the compiler that we don't want to ignore optionals
    | DendronConfigEntryCollection<any>
    | Record<any, DendronConfigEntry<any>>
    | DendronConfigEntry<any>
    | ((...args: any[]) => DendronConfigEntry<any>);
};

It is either:
- Another DendronConfigEntryCollection (of a sub-namespace),
- A Record that maps possible config enum keys to DendronConfigEntry
  - think NoteLookup's selection mode.
- A single DendronConfigEntry
- A function that produces DendronConfigEntry based on what value it is given.

Conventions

To maintain consistency in the configuration space, a few conventions have been established.
PR to the convention guide can be found here
Existing configurations that do not conform to these conventions are changed in this PR.

Pull Request Checklist

You can go to dendron pull requests to see full details for items in this checklist.

General

Quality Assurance

[~] add a test for the new feature
make sure all the existing tests pass
[~] do a spot check by running your feature with our test workspace
after you submit your pull request, check the output of our integration test and make sure all tests pass
- NOTE: if you running mac/linux, check the windows output and vice versa if you are developing on windows

Special Cases

[~] if your tests changes an existing snaphot, make sure that snapshots are updated
[~] if you are adding a new language feature (graphically visible in vscode/preview/publishing), make sure that it is included in test-workspace. We use this to manually inspect new changes and for auto regression testiing

Docs

Make sure that the PR title follows our commit style
Please summarize the feature or impact in 1-2 lines in the PR description
[.] If your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

kevinslin

This looks great. Left some minor comments but go ahead with this. For this commit, is the plan to carry out phase I of config migration? Can we have this ready to be merged for next week's release?

For deprecation notice, since we'll do automatic migration, we might not need to do any sort of deprecation notice besides announcing it in our release notes. FOr migrating to the new configuration, can we do it piecemeal?

Eg. Week1 -> migrate command config. Week2 -> migrate 2 more sections. Week3 -> migrate everything...

kevinslin · 2021-09-09T16:32:56Z

packages/common-all/src/types/configs/commands/commands.ts

+/**
+ * Constants holding all command config related {@link DendronConfigEntry}
+ */
+export const COMMANDS = {


thoughts between using constants vs enums? You can use Object.values to get all enum values

The values in the object are also constants that themselves holding other constants or functions that produce constants.

Are you suggesting we have nested enums (not sure if that's a thing)? or we flatten it out and have a giant enum that holds all possible labels and descriptions?

kevinslin · 2021-09-09T16:36:18Z

packages/common-all/src/types/configs/workspace/journal.ts

+ * @param value {@link dayOfWeekNumber}
+ * @returns DendronConfigEntry
+ */
+const FIRST_DAY_OF_WEEK = (


just a heads up that we're currently not supporting this option due to limitation in calendar widget. we'll add support back in eventually but FYI

I am aware of this. I also have been taking note on other configs with some peculiarities that we need to address once we start actually migrating.

hikchoi · 2021-09-10T02:08:04Z

This looks great. Left some minor comments but go ahead with this. For this commit, is the plan to carry out phase I of config migration? Can we have this ready to be merged for next week's release?

For deprecation notice, since we'll do automatic migration, we might not need to do any sort of deprecation notice besides announcing it in our release notes. FOr migrating to the new configuration, can we do it piecemeal?

Eg. Week1 -> migrate command config. Week2 -> migrate 2 more sections. Week3 -> migrate everything...

Yeah, I think it makes sense to announce what's going to change and then slowly migrate the configurations to the new one.
There are a lot of things to fix (splitting the effect of config so that the dupes in multiple areas are respected) so a piecemeal migration is likely better than one giant one.

I'll get it ready by next release, and also write up an announcement to add to the release notes of what the changes will entail.

hikchoi · 2021-09-13T14:18:45Z

UPDATE:

Please check the overview in the main body of this PR. Since this PR is waaaay too big, I go over the general structure of what is being added.

This PR does not change any existing behavior of the config. It just adds the newly organized config modules.
Over the next few weeks I will incrementally migrate the new configs in chunks.
Due to potential package namespace collision issues, I have not exported any of the newly added modules yet; they will be exported from @dendronhq/common-all as I actually migrate the configs.

I will also be adding a document that goes over exactly which config is going to be mapped to which in a separate docs PR, which can be added to the upcoming release notes.

hikchoi · 2021-09-14T13:16:16Z

Here is an exhaustive list of changes to every config key

This can also be found in [[Diff of All Changes|user.hikchoi.scratch.2021.09.14.diff-of-all-changes]]

Dendron Configurations

noCaching?: boolean;
- Renamed to enableCaching
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.enableCaching
maxPreviewsCached?: number;
- Now a required property
- Now explicitly defaults to the value 10
- New location: DendronConfig.workspace.maxPreviewsCached
noTelemetry?: boolean;
- Renamed to enableTelemetry
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.enableTelemetry
version: number;
- deprecated
dendronVersion?: string;
- New location: DendronConfig.workspace.dendronVersion
site: DendronSiteConfig;
- See Site Configurations below
lookup: LookupConfig;
- New location: DendronConfig.commands.lookup
- lookup.note.selectionType renamed to lookup.note.selectionMode
- enum values of selection modes are renamed
  - selectionExtract renamed to extract
  - selection2link renamed to link
journal: JournalConfig;
- New location: DendronConfig.workspace.journal
- journal.firstDayOfWeek temporarily removed
scratch?: ScratchConfig;
- Now a required property
- New location: DendronConfig.workspace.scratch
insertNoteLink?: InsertNoteLinkConfig;
- Now a required property
- aliasMode now explicitly defaults to none
- enableMultiSelect now explicitly defaults to false
- New location: DendronConfig.commands.insertNoteLink
- insertNoteLinkConfig.multiselect renamed to insertNoteLink.enableMultiSelect
workspaces?: { [key: string]: DWorkspaceEntry | undefined };
- New location: DendronConfig.workspace.workspaces
seeds?: { [key: string]: SeedEntry | undefined };
- New location: DendronConfig.workspace.seeds
vaults: DVault[];
- New location: DendronConfig.workspace.vaults
hooks?: DHookDict;
- New location: DendronConfig.workspace.hooks
lookupConfirmVaultOnCreate?: boolean;
- Now part of lookupConfig
- Renamed to confirmVaultOnCreate
- Now a required property
- Now explicitly defaults to false
- New location: DendronConfig.commands.lookup.note.confirmVaultOnCreate
useFMTitle?: boolean;
- Renamed to enableFMTitle
- Now a required property in global namespace.
- Now explicitly set to true in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
useNoteTitleForLink?: boolean;
- Renamed to enableNoteTitleForLink
- Now a required property in global namespace.
- Now explicitly set to true in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
mermaid?: boolean;
- Renamed to enableMermaid
- Now a required property in global namespace.
- Now explicitly set to true in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
useNunjucks?: boolean;
- Renamed to enableNunjucks
- Now a required property in global namespace.
- Now explicitly set to false in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
usePrettyRefs?: boolean;
- Renamed to enablePrettyRefs
- Now a required property in global namespace.
- Now explicitly set to true in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
useKatex?: boolean;
- Renamed to enableKatex
- Now a required property in global namespace.
- Now explicitly set to true in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
hierarchyDisplay?: boolean;
- Renamed to enabledHierarchyDisplay
- Now a required property in global namespace.
- Now explicitly set to true in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
hierarchyDisplayTitle?: string;
- Now explicitly set to children only in global namespace, but remains optional.
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
graph?: DendronGraphConfig;
- Now a required property
- zoomSpeed explicitly defaults to the value 1
- New location: DendronConfig.workspace.graph
noAutoCreateOnDefinition?: boolean;
- Renamed to enableAutoCreateOnDefinition
- Now a require property
- Now explicitly defaults to false
- New location: DendronConfig.workspace.enableAutoCreateOnDefinition
noLegacyNoteRef?: boolean;
- Renamed to enableLegacyNoteRef
- Now a required property in global namespace.
- Now explicitly set to false in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
noXVaultWikiLink?: boolean;
- Renamed to enableXVaultWikiLink
- Now a required property
- Now explicitly defaults to false
- New location: DendronConfig.workspace.enableXVaultWikiLink
initializeRemoteVaults?: boolean;
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.initializeRemoteVault
feedback?: boolean;
- New location: DendronConfig.workspace.feedback
apiEndpoint?: string;
- New location: DendronConfig.workspace.apiEndpoint
defaultInsertHierarchy?: string;
- Now part of insertNoteConfig
- renamed to initialValue
- Explicitly defaults to templates but remains optional
- New location: DendronConfig.commands.insertNote.initialValue
dev?: DendronDevConfig;
- New location: DendronConfig.dev
workspaceVaultSync?: DVaultSync;
- Renamed to workspaceVaultSyncMode
- Now a required property
- Now explicitly defaults to noCommit
- New location: DendronConfig.workspace.workspaceVaultSyncMode
randomNote?: RandomNoteConfig;
- Now a required property
- Properties randomNote.include and randomNote.exclude remains optional
- New location: DendronConfig.commands.randomNote
autoFoldFrontmatter?: boolean;
- Renamed to enableAutoFoldFrontmatter
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.enableAutoFoldFrontmatter
insertNoteIndex?: InsertNoteIndexConfig;
- Now a required property
- New location: DendronConfig.commands.insertNoteIndex
- insertNoteIndexConfig.marker renamed to insertNoteIndexConfig.enableMarker
- insertNoteIndexConfig.enableMarker is now a required property
- insertNoteIndexConfig.enableMarker now explicitly defaults to false
maxNoteLength?: number;
- Now a required property
- Now explicitly defaults to the value 204800
- New location: DendronConfig.workspace.maxNoteLength

Site Configurations

assetsPrefix?: string;
- New location: DendronConfig.publishing.assetsPrefix
canonicalBaseUrl?: string;
- New location: DendronConfig.publishing.canonicalBaseUrl
copyAssets?: boolean;
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.publishing.copyAssets
customHeaderPath?: string;
- New location: DendronConfig.publishing.customHeaderPath
ga_tracking?: string;
- Now part of GoogleAnalyticsConfig
- New location: DendronConfig.publishing.ga.tracking
siteFaviconPath?: string;
- New location: DendronConfig.publishing.siteFaviconPath
logo?: string;
- Renamed to logoPath
- New location: DendronConfig.publishing.logoPath
siteIndex?: string;
- New location: DendronConfig.publishing.siteIndex
siteHierarchies: string[];
- New location: DendronConfig.publishing.siteHierarchies
siteLastModified?: boolean;
- Renamed to enableSiteLastModified
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.publishing.enableSiteLastModified
siteRootDir: string;
- New location: DendronConfig.publishing.siteRootDir
siteRepoDir?: string;
- New location: DendronConfig.publishing.siteRepoDir
siteNotesDir?: string;
- deprecated
siteUrl?: string;
- New location: DendronConfig.publishing.siteUrl
githubCname?: string;
- Now part of GithubConfig
- Renamed to cname
- New location: DendronConfig.publishing.github.cname
gh_edit_link?: string;
- Now part of GithubConfig
- Renamed to enableEditLink
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.publishing.github.enableEditLink
gh_edit_link_text?: string;
- Now part of GithubConfig
- Renamed to editLinkText
- Remains optional but explicitly defaults to Edit this page on GitHub
- New location: DendronConfig.publishing.github.editLinkText
gh_edit_branch?: string;
- Now part of GithubConfig
- Renamed to editBranch
- Remains optional but explicitly defaults to main
- New location: DendronConfig.publishing.github.editBranch
gh_edit_view_mode?: "tree" | "edit";
- Now part of GithubConfig
- Renamed to editViewMode
- Remains optional but explicitly defaults to tree
- New location: DendronConfig.publishing.github.editViewMode
gh_edit_repository?: string;
- Now part of GithubConfig
- Renamed to editRepository
- New location: DendronConfig.publishing.github.editRepository
usePrettyRefs?: boolean;
- Renamed to enablePrettyRefs
- Now a required property in global namespace.
- Now explicitly set to true in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated in global, preview, and publishing
hideBlockAnchors?: boolean;
- deprecated
showFrontMatterTags?: boolean;
- Renamed to enableFrontmatterTags
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.publishing.enableFrontmatterTags
noRandomlyColoredTags?: boolean;
- Renamed to enableRandomlyColoredTags
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.publishing.enableRandomlyColoredTags
config?: { [key: string]: HierarchyConfig };
- Renamed to hierarchy
- New location: DendronConfig.publishing.hierarchy
duplicateNoteBehavior?: DuplicateNoteBehavior;
- New location: DendronConfig.publishing.duplicateNoteBehavior
writeStubs?: boolean;
- Now a required property
- Now explicitly defaults to false
- New location: DendronConfig.publishing.writeStubs
title?: string;
- Now part of SEOConfig
- New location: DendronConfig.publishing.seo.title
description?: string;
- Now part of SEOConfig
- New location: DendronConfig.publishing.seo.description
author?: string;
- Now part of SEOConfig
- New location: DendronConfig.publishing.seo.author
twitter?: string;
- Now part of SEOConfig
- New location: DendronConfig.publishing.seo.twitter
image?: string;
- Now part of SEOConfig
- New location: DendronConfig.publishing.seo.image
useContainers?: boolean;
- Renamed to enableContainers
- Now a required property
- Now explicitly defaults to false
- New location: DendronConfig.publishing.enableContainers
generateChangelog?: boolean;
- Now a required property
- Now explicitly defaults to false
- New location: DendronConfig.publishing.generateChangelog
previewPort?: boolean;
- Type fixed to number
- New location: DendronConfig.publishing.previewPort
segmentKey?: string;
- New location: DendronConfig.publishing.segmentKey
cognitoUserPoolId?: string;
- New location: DendronConfig.publishing.cognitoUserPoolId
cognitoClientId?: string;
- New location: DendronConfig.publishing.cognitoClientId
usePrettyLinks?: boolean;
- Renamed to enablePrettyLinks
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.publishing.enablePrettyLinks

kevinslin · 2021-09-15T18:38:07Z

Great job on putting in the ground work. Configuration renames look good, just a few changes suggested below

noCaching?: boolean;
- Renamed to enableCaching
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.enableCaching
we initially had this because we weren't sure if caching would break things. it hasn't so far - lets just remove this entirely
noTelemetry?: boolean;
- Renamed to enableTelemetry
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.enableTelemetry
can we change this to disableTelemetry and keep it as optional?
noLegacyNoteRef?: boolean;
- Renamed to enableLegacyNoteRef
- Now a required property in global namespace.
- Now explicitly set to false in global namespace.
- Remains optional in preview and publishing
- When explicitly set in preview or publishing namespace, it will have precedence over the value set in global namespace.
- Now duplicated across global, preview, and publising namespace
we should just disable this altogether and remove the option
initializeRemoteVaults?: boolean;
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.initializeRemoteVault
change to enableRemoteVaultInit
autoFoldFrontmatter?: boolean;
- Renamed to enableAutoFoldFrontmatter
- Now a required property
- Now explicitly defaults to true
- New location: DendronConfig.workspace.enableAutoFoldFrontmatter
this has actually caused a bunch of issues. can we change the default to false?

kevinslin · 2021-09-15T18:38:26Z

Note that value is defined to be optional, as some configs can have arbitrary values. In which case passing in the correct type T is meaningless, but is there for completeness' sake.

typescript supports initializing generics, would rewrite to the following in that case

export type DendronConfigEntry<T=any> = {
  value?: T;
  label: string;
  desc: string;
};

kevinslin

see config changes in conversation

kevinslin · 2021-09-15T18:40:56Z

packages/common-all/src/types/configs/base.ts

+ * For config entries that can be an arbitrary value, only specify the label and description.
+ * For config entries that have pre-defined choices, provide the value as well as label and description specific to that value.
+ */
+export type DendronConfigEntry<T> = {


since value is optional we can make T=any to cut down on boilerplate

TIL 😅 still so much to learn about ts.

hikchoi added 3 commits September 6, 2021 15:57

spike: draft implementation of consolidated configs

1ea9769

chore: add docstrings

52dc0f0

chore: clean up and add more docstrings

afabae2

auto-assign bot requested review from jonathanyeung and kevinslin September 6, 2021 11:57

auto-assign bot assigned jonathanyeung and kevinslin Sep 6, 2021

hikchoi marked this pull request as draft September 6, 2021 11:57

hikchoi added 9 commits September 9, 2021 10:13

chore: refactor common types

5884377

chore: add new scratch config

34ed614

chore: add new insert note index configs

5fab3e1

chore: change generic type for DendronConfigEntry

8ccc860

chore: respect optional when generating defaults

8c95505

chore: add new random note config

8acc3d5

chore: add more top level namespaces

a9df10a

chore: add namespace for insert note

f5e1e75

chore: bunch more stuff

142fac0

kevinslin reviewed Sep 9, 2021

View reviewed changes

hikchoi added 11 commits September 11, 2021 00:02

chore: add remaining workspace configs

9c41819

chore: add graph configs

6780bea

chore: add rest of publishing configs

c5c22be

chore: add global configs

aca742d

chore: add dev configs

67b1e6e

chore: add preview configs

72e099b

chore: add dev configs to top level

3d06a31

chore: define generic type for config entry collection

864561d

chore: clean up commands namespace

5012ab1

chore: narrow down collection type definition

e0cae85

chore: clean up workspace namespace

a20e8f8

hikchoi added 6 commits September 13, 2021 15:40

chore: clean up global namespace

33653b1

chore: clean up dev namespace

fc180be

chore: clean up preview namespace

dfa32ff

chore: clean up publishing namespace

1fa756f

chore: more cleanup

69bc20b

chore: more and more cleanup

51900ef

hikchoi marked this pull request as ready for review September 13, 2021 14:18

auto-assign bot requested a review from SeriousBug September 13, 2021 14:18

auto-assign bot assigned SeriousBug Sep 13, 2021

hikchoi added 2 commits September 14, 2021 00:31

chore: fix wording, add omitted configs

cbc92c4

chore: add missing config entries in workspace

517facc

chore: conform to naming convention, various fixes

b574dda

kevinslin requested changes Sep 15, 2021

View reviewed changes

hikchoi added 3 commits September 16, 2021 13:25

chore: remove enableCaching config

dc13a17

chore: renaming and deletions

2ada327

chore: reduce generic type boilerplate

609873b

kevinslin approved these changes Sep 17, 2021

View reviewed changes

kevinslin merged commit 177ac92 into master Sep 17, 2021

kevinslin deleted the feat/consolidate-dendron-configs branch September 17, 2021 14:45

hikchoi mentioned this pull request Sep 25, 2021

enhance: Leave trace on source note while using selectionExtract #1373

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: consolidate dendron configs #1295

feat: consolidate dendron configs #1295

Uh oh!

hikchoi commented Sep 6, 2021 •

edited

Loading

Uh oh!

kevinslin left a comment

Uh oh!

kevinslin Sep 9, 2021

Uh oh!

hikchoi Sep 10, 2021

Uh oh!

kevinslin Sep 9, 2021

Uh oh!

hikchoi Sep 10, 2021

Uh oh!

hikchoi commented Sep 10, 2021

Uh oh!

hikchoi commented Sep 13, 2021

Uh oh!

hikchoi commented Sep 14, 2021 •

edited

Loading

Uh oh!

kevinslin commented Sep 15, 2021

Uh oh!

kevinslin commented Sep 15, 2021

Uh oh!

kevinslin left a comment

Uh oh!

kevinslin Sep 15, 2021

Uh oh!

hikchoi Sep 15, 2021

Uh oh!

Uh oh!

Uh oh!

feat: consolidate dendron configs #1295

feat: consolidate dendron configs #1295

Uh oh!

Conversation

hikchoi commented Sep 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

feat: consolidate dendron configs

Overview of changes

Config type definitions

Constants

Conventions

Pull Request Checklist

General

Quality Assurance

Special Cases

Docs

Uh oh!

kevinslin left a comment

Choose a reason for hiding this comment

Uh oh!

kevinslin Sep 9, 2021

Choose a reason for hiding this comment

Uh oh!

hikchoi Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

kevinslin Sep 9, 2021

Choose a reason for hiding this comment

Uh oh!

hikchoi Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

hikchoi commented Sep 10, 2021

Uh oh!

hikchoi commented Sep 13, 2021

Uh oh!

hikchoi commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dendron Configurations

Site Configurations

Uh oh!

kevinslin commented Sep 15, 2021

Uh oh!

kevinslin commented Sep 15, 2021

Uh oh!

kevinslin left a comment

Choose a reason for hiding this comment

Uh oh!

kevinslin Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

hikchoi Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hikchoi commented Sep 6, 2021 •

edited

Loading

hikchoi commented Sep 14, 2021 •

edited

Loading