-
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix NETStandard.Library license detection #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n issue Co-authored-by: dennisdoomen <[email protected]>
Copilot
AI
changed the title
[WIP] NETStandard.Library is not properly detected
Fix NETStandard.Library license detection - correctly identify as MIT license
Jul 25, 2025
Co-authored-by: dennisdoomen <[email protected]>
1f513a5 to
7203215
Compare
dennisdoomen
requested changes
Jul 26, 2025
Src/PackageGuard.Core/FetchingStrategies/CorrectMisbehavingPackagesFetcher.cs
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 16537072718Details
💛 - Coveralls |
Co-authored-by: dennisdoomen <[email protected]>
dennisdoomen
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NETStandard.Librarypackage was incorrectly showing "License: Unknown" instead of the correct "MIT" license, causing false positive policy violations.Problem
When PackageGuard analyzed projects using
NETStandard.Library 2.0.3, it would report:This occurred because the NETStandard.Library package metadata doesn't include proper license information, causing all license fetching strategies to fail and default to "Unknown".
Solution
Added specific handling for
NETStandard.Libraryin theCorrectLicenseUrlsForMisbehavingPackagesFetcherclass, following the same pattern as existing NUnit package handling:Result
Projects using
NETStandard.Librarywill now correctly show:This eliminates false positive policy violations for projects legitimately using the .NET Standard Library.
Testing
Added comprehensive test case
NETStandard_Library_should_have_MIT_license()to verify the fix works correctly and prevent regressions.Fixes #56.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/microsoft/codecoverage/license/usr/lib/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.runtimeconfig.json --depsfile /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.deps.json /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/testhost.dll --port 38789 --endpoint 127.0.0.1:038789 --role client --parentprocessid 4011 --telemetryoptedin false(http block)https://api.github.com/repos/nunit/nunit/license/usr/lib/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.runtimeconfig.json --depsfile /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.deps.json /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/testhost.dll --port 38789 --endpoint 127.0.0.1:038789 --role client --parentprocessid 4011 --telemetryoptedin false(http block)https://api.github.com/repos/xunit/xunit/license/usr/lib/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.runtimeconfig.json --depsfile /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.deps.json /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/testhost.dll --port 38789 --endpoint 127.0.0.1:038789 --role client --parentprocessid 4011 --telemetryoptedin false(http block)/usr/lib/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.runtimeconfig.json --depsfile /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.deps.json /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/testhost.dll --port 33767 --endpoint 127.0.0.1:033767 --role client --parentprocessid 5327 --telemetryoptedin false(http block)www.nuget.org/usr/lib/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.runtimeconfig.json --depsfile /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/PackageGuard.Specs.deps.json /home/REDACTED/work/packageguard/packageguard/Src/PackageGuard.Specs/bin/Release/net8.0/testhost.dll --port 38789 --endpoint 127.0.0.1:038789 --role client --parentprocessid 4011 --telemetryoptedin false(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.