Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
namespace PackageGuard.Core.FetchingStrategies;

/// <summary>
/// A specialized license fetcher that corrects the repository URL for packages that have historically used the wrong URL.
/// A specialized license fetcher that corrects the metadata for packages that have historically used the wrong repository URL or missed license information.
/// </summary>
internal class CorrectLicenseUrlsForMisbehavingPackagesFetcher : IFetchLicense
internal class CorrectMisbehavingPackagesFetcher : IFetchLicense
{
public Task FetchLicenseAsync(PackageInfo package)
{
Expand All @@ -13,6 +13,12 @@ public Task FetchLicenseAsync(PackageInfo package)
package.RepositoryUrl = "https://github.com/nunit/nunit";
}

if (package.Name.Equals("NETStandard.Library", StringComparison.InvariantCultureIgnoreCase))
{
package.License = "MIT";
package.RepositoryUrl = "https://github.com/dotnet/standard";
}

return Task.CompletedTask;
}
}
2 changes: 1 addition & 1 deletion Src/PackageGuard.Core/LicenseFetcher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public sealed class LicenseFetcher(ILogger logger, string? gitHubApiKey = null)
{
private readonly IEnumerable<IFetchLicense> fetchers =
[
new CorrectLicenseUrlsForMisbehavingPackagesFetcher(),
new CorrectMisbehavingPackagesFetcher(),
new GitHubLicenseFetcher(gitHubApiKey),
new UrlLicenseFetcher(logger)
];
Expand Down
22 changes: 22 additions & 0 deletions Src/PackageGuard.Specs/LicenseFetcherSpecs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,26 @@ public async Task A_no_assertion_license_is_treated_as_unknown()
// Assert
package.License.Should().Be("Unknown");
}

[TestMethod]
public async Task Reports_the_correct_license_for_net_standard_libraries()
{
// Arrange
var fetcher = new LicenseFetcher(NullLogger.Instance, gitHubApiKey);

var package = new PackageInfo
{
Name = "NETStandard.Library",
Version = "2.0.3",
License = null,
LicenseUrl = null,
RepositoryUrl = null
};

// Act
await fetcher.AmendWithMissingLicenseInformation(package);

// Assert
package.License.Should().Be("MIT");
}
}