chore: Update SNS Aggregator types for potentially any IC commit #7079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
reviewed
Jul 8, 2025
| @@ -23,20 +23,20 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - name: Install didc | |||
| run: scripts/install-didc | |||
| - name: Find newer IC release, if any | |||
| - name: Find newer IC commit, if any | |||
There was a problem hiding this comment.
This could mean we're using a non-released commit (which shouldn't be a problem if we are in the habit of keeping master in a releasable state). Just thought I should mention it.
max-dfinity
approved these changes
Jul 8, 2025
yhabib
approved these changes
Jul 8, 2025
2 tasks
aterga
force-pushed
the
arshavir/update-sns-aggregator-types-on-each-ic-commit
branch
from
37801c5 to
2aebd88
Compare
yhabib
force-pushed
the
arshavir/update-sns-aggregator-types-on-each-ic-commit
branch
from
2aebd88 to
bdb82f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IC repo releases are tied to replica releases, whereas SNS types can be updated and proposed on any commit. It makes no sense to wait for a replica release to update the SNS Aggregator.
Changes
Instead of checking for the latest releases, the
update-aggregatorCI job now checks for any new IC commits.Tests
Trial and error.
Todos