Skip to content

chore: Update SNS Aggregator types for potentially any IC commit #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Update SNS Aggregator types for potentially any IC commit #7079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/update-aggregator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@ jobs:
- uses: actions/checkout@v4
- name: Install didc
run: scripts/install-didc
- name: Find newer IC release, if any
- name: Find newer IC commit, if any
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could mean we're using a non-released commit (which shouldn't be a problem if we are in the habit of keeping master in a releasable state). Just thought I should mention it.

id: update
run: |
current_release="$(jq -r .defaults.build.config.IC_COMMIT_FOR_SNS_AGGREGATOR config.json)"
echo "Current IC release: $current_release"
latest_release=$(curl -sSL https://api.github.com/repos/dfinity/ic/releases/latest | jq .tag_name -r)
echo "Latest IC release: $latest_release"
current_commit="$(jq -r .defaults.build.config.IC_COMMIT_FOR_SNS_AGGREGATOR config.json)"
echo "Current IC commit: $current_commit"
latest_commit=$(curl -sSL https://api.github.com/repos/dfinity/ic/commits/master | jq .sha -r)
echo "Latest IC commit: $latest_commit"
{
if [ "$current_release" == "$latest_release" ]
if [ "$current_commit" == "$latest_commit" ]
then
echo "updated=0"
else
echo "updated=1"
echo "release=$latest_release"
echo "commit=$latest_commit"
fi
} >> "$GITHUB_OUTPUT"
- name: Install sponge
Expand All @@ -46,7 +46,7 @@ jobs:
if: ${{ steps.update.outputs.updated == '1' }}
run: |
# Update candid files
scripts/update_ic_commit --crate sns_aggregator --ic_commit "${{ steps.update.outputs.release }}"
scripts/update_ic_commit --crate sns_aggregator --ic_commit "${{ steps.update.outputs.commit }}"
# Show changes
echo "Git status:"
git status
Expand Down