Improve pipeline dashboard test coverage #3091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
force-pushed
the
fix/dashboard-tests
branch
from
54a8303 to
c76e73d
Compare
sh-rp
changed the title
zilto
requested changes
Sep 17, 2025
Collaborator
zilto
left a comment
zilto
left a comment
There was a problem hiding this comment.
LGTM. Small changes recommended
alkaline-0
pushed a commit
that referenced
this pull request
Sep 18, 2025
* disable most tests * try correct windows command for runnig marimo e2e tests * try without timeout * test only launch marimo * bump python version * try install playwright deps * fix e2e tests for dashboard on windows * enable e2e tests for dashboard * test macos 14 for dashboard e2e tests * add basic tests for ui elements * improve ui elements tests * revert changes to main github workflow * review fixes --------- Co-authored-by: Your Name <[email protected]>
alkaline-0
added a commit
that referenced
this pull request
Sep 19, 2025
* feat: add method to create dataset names with validation for staging dataset (#XXXX) * Introduced `create_dataset_names` static method in `WithStagingDataset` class. * Added validation to ensure staging dataset name is not the same as the final dataset name, raising a ValueError if they match. * Updated documentation for the new method and error handling. * refactor: enhance create_dataset_names method with improved error messaging and add unit tests * Reformatted the `create_dataset_names` method for better readability. * Improved error messages to clarify the consequences of identical dataset names. * Added unit tests for `create_dataset_names` to validate functionality and error handling. * refactor: update dataset name handling in destination clients * Replaced direct calls to `normalize_dataset_name` and `normalize_staging_dataset_name` with a new method `create_dataset_names` in multiple destination client classes. * This change improves consistency in dataset name generation across various implementations, ensuring proper handling of dataset names and staging datasets. * refactor: improve formatting and readability of dataset name assignments in destination clients * Updated dataset name assignments in multiple destination client classes to enhance readability by breaking long lines. * Maintained consistency in the use of the `create_dataset_names` method across implementations. * refactor: improve formatting and readability of dataset name assignments in destination clients * Updated dataset name assignments in multiple destination client classes to enhance readability by breaking long lines. * Maintained consistency in the use of the `create_dataset_names` method across implementations. * Improve pipeline dashboard test coverage (#3091) * disable most tests * try correct windows command for runnig marimo e2e tests * try without timeout * test only launch marimo * bump python version * try install playwright deps * fix e2e tests for dashboard on windows * enable e2e tests for dashboard * test macos 14 for dashboard e2e tests * add basic tests for ui elements * improve ui elements tests * revert changes to main github workflow * review fixes --------- Co-authored-by: Your Name <[email protected]> * Fix/67 normalizer child table behavior (#3048) * add code to fix behavior of normalizer when None or primitives are encountered for child tables (cherry picked from commit 5f44278) * fixes one existing test that would not work with cached schema otherwise * add tests and small fixes to dashboard * fix implementation and add more tests * Long names handled, get_nested_tables test, cached table lookups * relational normalizer returns unshortened parent bath * Schema contract test added --------- Co-authored-by: anuunchin <[email protected]> * Add redirect from dlt-plus page (#3084) * docs: update staging dataset naming guidelines to prevent data loss Added important notes and examples to the staging dataset configuration section, emphasizing the need for unique names between staging and final datasets to avoid `ValueError` and potential data loss during setup commands. --------- Co-authored-by: David Scharf <[email protected]> Co-authored-by: Your Name <[email protected]> Co-authored-by: anuunchin <[email protected]> Co-authored-by: Violetta Mishechkina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves test coverage for pipeline dashboard