-
Notifications
You must be signed in to change notification settings - Fork 415
Improve pipeline dashboard test coverage #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c76e73d
disable most tests
sh-rp b532195
try correct windows command for runnig marimo e2e tests
sh-rp d949e73
try without timeout
sh-rp 01ba2e2
test only launch marimo
sh-rp da65076
bump python version
sh-rp 09157bf
try install playwright deps
sh-rp 24c9e6a
fix e2e tests for dashboard on windows
sh-rp 8205786
enable e2e tests for dashboard
1c8a317
test macos 14 for dashboard e2e tests
sh-rp 9a2650a
add basic tests for ui elements
sh-rp 194653c
improve ui elements tests
sh-rp 34f31c5
revert changes to main github workflow
sh-rp b19ace4
review fixes
sh-rp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import marimo as mo | ||
| import dlt | ||
|
|
||
|
|
||
| from dlt.helpers.dashboard.ui_elements import ( | ||
| build_title_and_subtitle, | ||
| build_page_header, | ||
| build_error_callout, | ||
| ) | ||
|
|
||
|
|
||
| def test_build_title_and_subtitle(): | ||
| title = "Test Title" | ||
| subtitle = "Test Subtitle" | ||
| html = build_title_and_subtitle(title, subtitle).text | ||
| assert title in html | ||
| assert subtitle in html | ||
|
|
||
|
|
||
| def test_build_page_header(success_pipeline_duckdb: dlt.Pipeline): | ||
| title = "Test Title" | ||
| subtitle = "Test Subtitle" | ||
| subtitle_long = "Test Alternative Subtitle Long" | ||
|
|
||
| # not opened | ||
| html = build_page_header( | ||
| success_pipeline_duckdb, title, subtitle, subtitle_long, mo.ui.button() | ||
| )[0].text | ||
| assert title in html | ||
| assert subtitle in html | ||
| assert subtitle_long not in html | ||
|
|
||
| # opened | ||
| html = build_page_header( | ||
| success_pipeline_duckdb, title, subtitle, subtitle_long, mo.ui.button(value=True) | ||
| )[0].text | ||
| assert title in html | ||
| assert subtitle not in html | ||
| assert subtitle_long in html | ||
|
|
||
|
|
||
| def test_build_error_callout(): | ||
| message = "Test Message" | ||
| code = "Test Code" | ||
| traceback_string = "Test Traceback String" | ||
| html = build_error_callout(message, code, traceback_string).text | ||
| assert message in html | ||
| assert code in html | ||
| assert traceback_string in html |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.