feat/3198-add-workspace-info-and-profile-selection #3295

alkaline-0 · 2025-11-06T14:14:33Z

Description

Added a Profile dropdown to the dashboard.
Updated header layout to show Profile, Workspace, and Pipeline inline.
Introduced utils_discover_profiles to discover profiles and handle selection.
Made pipeline discovery reactive to selected Profile (shows only pipelines for that profile).
Added Makefile target to run profile e2e tests.
Created profile e2e tests to verify:

Workspace label reflects selected profile.
Each profile only sees its own pipelines.
Switching profiles clears stale pipeline selection.

Related Issues

3198

How to Test

Run profile e2e tests:
make dashboard-test-profiles

Manually:

Start the dashboard in a workspace (with .dlt/.workspace).
Use the Profile dropdown to switch profiles; Workspace label and Pipeline list should update accordingly.

Additional Context

Server must run in a workspace context:
cwd = workspace root
URL ?profile= is supported for initial load; ongoing changes are via the dropdown.

cloudflare-workers-and-pages · 2025-11-06T14:17:26Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	docs	`1559ead`	Commit Preview URL Branch Preview URL	Nov 13 2025, 07:37 PM

sh-rp

The implementation in the dashboard app is very good. I have some small notes there and this one: When you have selected a pipeline and switch to a profile where this pipeline has not been run, the app crashes. You should get a helpful error message there.

For the tests we can do the following:

Let's convert the previously existing tests in such a way, that the dashoard server gets launched and killed from the test code too, then we can get rid of the extra makefile command for this.
For the new tests:
- Create a new example workspace in tests/workspaces/cases which has two pipelines. You should be able to put all the needed code for the workspace in there including different settings for the profiles. You can even change the pipeline name via a config setting so we can more easy test later.
- Use with isolated_workspace to set up a workspace in the e2e tests and start the dashboad in the cwd of this workspace. You should be able to get the basefolder of this isolated workspace and set it for the dashboard command. When you run pipelines with various profiles in this isolated workspace, you should see the dashboard populating

sh-rp · 2025-11-07T15:25:56Z

dlt/_workspace/helpers/dashboard/ui_elements.py

+
+def build_workspace_label() -> Any:
+    """Show workspace name, or '_' if not set/available."""
+    run_context = dlt.current.run_context()


Here you should check wether it is a WorkspaceRunContext, if it is not, then this whole workspace section should not appear. See comment above.

sh-rp · 2025-11-07T15:26:28Z

dlt/_workspace/helpers/dashboard/ui_elements.py

    return mo.vstack(_result)


+def build_run_context_inline_label() -> Any:


This lable / dropdown should not appear at all in a non-workspace dashboard. If a user opens the dashboad in a folder where there is no workspace, it should just look the way it did before.

sh-rp · 2025-11-07T15:28:52Z

dlt/_workspace/helpers/dashboard/ui_elements.py

+
+def build_labeled_inline(label_text: str, content: Any) -> Any:
+    """Inline label + content, matching selector header design."""
+    return mo.hstack([mo.md(f"<small>{label_text}:</small>"), content], align="center").style(


I think you can set the gap directly on the hstack, no need to call style:
https://docs.marimo.io/api/layouts/stacks/

sh-rp · 2025-11-07T15:29:15Z

dlt/_workspace/helpers/dashboard/ui_elements.py

+    )
+
+
+def build_tabs_spacer(num_tabs: int = 2) -> Any:


Can this not also be solved by a gap on the stack that these items are where you use this?
https://docs.marimo.io/api/layouts/stacks/. Adding tabs is a bit hacky.

sh-rp · 2025-11-07T15:30:10Z

dlt/_workspace/helpers/dashboard/dlt_dashboard.py

+    """Discover profiles and return a single-select multiselect, similar to pipelines."""
+    run_context = dlt.current.run_context()
+
+    def _profiles_from_run_context():


this does not need to be an inner function, you can just write all the code without wrapping it, no?

sh-rp · 2025-11-07T15:49:27Z

dlt/_workspace/helpers/dashboard/dlt_dashboard.py



 @app.cell(hide_code=True)
 def utils_discover_pipelines(


I think you can revert all changes in this function, it should still work.

- Added a dropdown for profile selection in the dashboard interface. - Updated the layout to display profile and workspace information inline with pipeline selection. - Introduced a new utility function to discover profiles and return a dropdown for selection. - Added a new Makefile target for running profile-specific end-to-end tests. - Created a new test file for end-to-end testing of profile functionality in the dashboard.

- Modified Makefile to exclude 'test_profiles_e2e' from e2e tests for both headless and headed runs. - Updated GitHub Actions workflow to reflect the same exclusion for dashboard e2e tests, ensuring consistency across local and CI environments.

- Introduced inline controls for profile and workspace information in the dashboard. - Updated layout to improve the organization of elements, ensuring a cleaner interface. - Simplified utility functions for profile discovery and selection. - Adjusted labels for dropdowns to provide clearer context for users.

- Streamlined the profile discovery process by consolidating checks for profile context. - Enhanced dropdown initialization for profile selection, ensuring it reflects the current state and available options. - Improved the handling of query parameters and CLI arguments for profile switching, maintaining user context more effectively.

…e handling - Reordered parameters in the home function to enhance clarity. - Updated the utils_discover_pipelines function to include profile selection logic, ensuring the correct profile is active during pipeline discovery. - Modified utils_discover_profiles to streamline profile selection and remove redundant profile switching logic. - Enhanced the utils_cli_args_and_query_vars_config function to better manage query parameters and CLI arguments related to profiles.

- Updated Makefile to simplify e2e test commands by removing exclusions for profile tests. - Enhanced GitHub Actions workflow to align with the updated test commands. - Introduced new fixtures in `conftest.py` for better management of dashboard server and pipeline setups. - Added a new test for workspace profiles to validate profile-specific behavior in the dashboard. - Removed outdated `test_profiles_e2e.py` file to streamline the test suite.

…ompatibility - Introduced a new utility function `_normpath` in `conftest.py` to ensure paths are normalized to Unix style and lowercase on Windows.

rudolfix

LGTM!

I changed a few thing to make it work on windows. All the problems were coming from how marimo was launched: a child process was spawned that created another child process with actual server. that was unkillable in windows and was leaving running processes and locked files

rudolfix

LGTM again!

alkaline-0 force-pushed the feat/3198-add-workspace-info-and-profile-selector branch 2 times, most recently from 3ebbc28 to 1ac9e43 Compare November 7, 2025 12:54

sh-rp requested changes Nov 7, 2025

View reviewed changes

alkaline-0 added 9 commits November 12, 2025 17:19

removed unnecessary styling

64bb48a

reverted pipeline changes

651231b

Fixed UI for now

b9987b4

alkaline-0 force-pushed the feat/3198-add-workspace-info-and-profile-selector branch from 3fe268b to 7a0de28 Compare November 12, 2025 16:19

handled formatting problem and adapted CI to use the new test commands

4e0ea46

alkaline-0 force-pushed the feat/3198-add-workspace-info-and-profile-selector branch from 5665454 to 4e0ea46 Compare November 12, 2025 16:33

Fixing formatting of a file because it's failing the tests

006c5a9

alkaline-0 marked this pull request as ready for review November 12, 2025 19:26

alkaline-0 requested a review from sh-rp November 12, 2025 19:32

alkaline-0 self-assigned this Nov 12, 2025

alkaline-0 requested a review from rudolfix November 12, 2025 19:34

Refactor dashboard test setup to normalize paths for cross-platform c…

aa9f8df

…ompatibility - Introduced a new utility function `_normpath` in `conftest.py` to ensure paths are normalized to Unix style and lowercase on Windows.

alkaline-0 force-pushed the feat/3198-add-workspace-info-and-profile-selector branch from 7665236 to aa9f8df Compare November 12, 2025 19:39

alkaline-0 requested review from rudolfix and sh-rp and removed request for rudolfix and sh-rp November 12, 2025 19:40

rudolfix added 2 commits November 13, 2025 16:58

splits dashboard cli gen and run, adds async run in context manager

d42dddf

runs dashboards directly in e2e tests

3a06d85

rudolfix previously approved these changes Nov 13, 2025

View reviewed changes

rudolfix dismissed their stale review via 13c7df2 November 13, 2025 16:46

uses different port on profile test

1946293

rudolfix force-pushed the feat/3198-add-workspace-info-and-profile-selector branch from 13c7df2 to 1946293 Compare November 13, 2025 17:21

rudolfix added 3 commits November 13, 2025 19:03

removes networkidle wait

9ca9b05

updates e2e github workflow

5125a6b

removes race conditions, splits tests

1559ead

rudolfix approved these changes Nov 13, 2025

View reviewed changes

rudolfix removed the request for review from sh-rp November 13, 2025 20:47

alkaline-0 requested a review from sh-rp November 13, 2025 21:25

sh-rp approved these changes Nov 14, 2025

View reviewed changes

alkaline-0 merged commit 4d25a6c into devel Nov 14, 2025
71 of 72 checks passed

alkaline-0 deleted the feat/3198-add-workspace-info-and-profile-selector branch November 14, 2025 17:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat/3198-add-workspace-info-and-profile-selection #3295

feat/3198-add-workspace-info-and-profile-selection #3295

Uh oh!

alkaline-0 commented Nov 6, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

sh-rp left a comment

Uh oh!

sh-rp Nov 7, 2025

Uh oh!

sh-rp Nov 7, 2025

Uh oh!

sh-rp Nov 7, 2025

Uh oh!

sh-rp Nov 7, 2025

Uh oh!

sh-rp Nov 7, 2025

Uh oh!

sh-rp Nov 7, 2025

Uh oh!

rudolfix left a comment

Uh oh!

rudolfix left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		return mo.vstack(_result)


		def build_run_context_inline_label() -> Any:

feat/3198-add-workspace-info-and-profile-selection #3295

feat/3198-add-workspace-info-and-profile-selection #3295

Uh oh!

Conversation

alkaline-0 commented Nov 6, 2025

Description

Related Issues

How to Test

Manually:

Additional Context

Uh oh!

cloudflare-workers-and-pages bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

sh-rp left a comment

Choose a reason for hiding this comment

Uh oh!

sh-rp Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sh-rp Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sh-rp Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sh-rp Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sh-rp Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sh-rp Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

rudolfix left a comment

Choose a reason for hiding this comment

Uh oh!

rudolfix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cloudflare-workers-and-pages bot commented Nov 6, 2025 •

edited

Loading