Fix name clash in CHECK macro#627
Merged
Merged
Conversation
Contributor
Author
|
@trivialfis Can you review? |
Member
|
Why is this a follow up to #611? |
Contributor
Author
|
@trivialfis Sorry I meant to say #626 |
trivialfis
approved these changes
Jun 16, 2020
szha
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #626
Address 25aa415#r39900770. A downstream application may use a local variable named
errand that would clash with the variableerrused in DMLC logging. Rename the latter variable to__dmlc__log__err, which (I hope) is unlikely to be used in a downstream application.@szha
Related: Library writers often use symbols with double underscores to avoid name clashes.
cc @okuvshynov @junrushao1994 @trivialfis