[logging] fix leak in LOG(FATAL)#626
Merged
Merged
Conversation
As trivialfis pointed out, even though this allocation happens before fatal is logged, that might be caught, and process might continue execution. Use unique_ptr instead.
Contributor
Author
|
reported at #625 |
hcho3
approved these changes
Jun 10, 2020
Member
Closed
Member
|
@okuvshynov Thanks for fixing the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As trivialfis pointed out, even though this allocation happens right before
fatal is logged, that might be caught, and process might continue
execution.
Use unique_ptr instead.