Add "make test" during build (as requested by upstream) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still no dice for #20: $ docker run -it --rm 08c33800554f sh
/ $ memcached -o modern
Segmentation faultWill try to follow the debugging steps in memcached/memcached#286 and report back there. Meanwhile, I'll remove that patch from this PR. |
|
Doh, I got too excited and forgot that I have to redirect to |
tianon
force-pushed
the
make-test
branch
2 times, most recently
from
6f9dab1 to
b7b77f4
Compare
|
Build time differences (still worth adding, IMO):
|
yosifkit
approved these changes
Jul 17, 2017
yosifkit
approved these changes
Jul 17, 2017
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 18, 2017
- `ghost`: 0.11.11 - `golang`: minor comment change - `memcached`: Alpine 3.6, Debian Stretch (docker-library/memcached#24), run tests during build, apply Alpine patch for segfault (docker-library/memcached#22) - `mysql`: 8.0.2, 5.7.19, 5.6.37, 5.5.57 - `python`: add explicit `jessie` and `alpine3.4` aliases (docker-library/python#215), add `stretch` variant (docker-library/python#208) - `redmine`: 3.4.2 - `rocket.chat`: 0.57.2 - `ruby`: bundler 1.15.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitly removes a few failing tests in Alpine while we work with upstream to figure out why they're failing and hopefully get them fixed.
See also memcached/memcached#286 (comment).
This also applies the patch in memcached/memcached@1831634, which fixes #20.