Skip to content

Add Debian Stretch variants #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 17, 2017
Merged

Add Debian Stretch variants #208

merged 8 commits into from
Jul 17, 2017

Conversation

JayH5
Copy link
Contributor

@JayH5 JayH5 commented Jun 21, 2017

This adds a stretch variant to the 2.7, 3.6, and 3.6-rc versions. These images are based on the buildpack-deps:stretch image.

I would like the default Debian version to be Stretch, but that will probably break too much stuff. I'd also like a slim Stretch image but that would probably create too many variations?

I copied the command to optionally install gnupg2 and dirmngr from the GCC 4.9 image.

@owais
Copy link

owais commented Jun 30, 2017

Having stretch as a variant would be great. jessie does not contain all new packages now and not everything is back ported. This doesn't have to become default. Just a variant would be great for now.

@tianon
Copy link
Member

tianon commented Jul 5, 2017

Do you think we'd be able to get away without python:2.7-stretch for now? (probably not? 😞)

We already support a fairly large number of variations here, and I'd like to try and keep that as limited as we can. 😅

$ bashbrew list --uniq python
python:2.7.13
python:2.7.13-slim
python:2.7.13-alpine
python:2.7.13-alpine3.6
python:2.7.13-wheezy
python:2.7.13-onbuild
python:2.7.13-windowsservercore
python:3.3.6
python:3.3.6-slim
python:3.3.6-alpine
python:3.3.6-wheezy
python:3.3.6-onbuild
python:3.4.6
python:3.4.6-slim
python:3.4.6-alpine
python:3.4.6-wheezy
python:3.4.6-onbuild
python:3.5.3
python:3.5.3-slim
python:3.5.3-alpine
python:3.5.3-onbuild
python:3.5.3-windowsservercore
python:3.6.1
python:3.6.1-slim
python:3.6.1-alpine
python:3.6.1-alpine3.6
python:3.6.1-onbuild
python:3.6.1-windowsservercore
python:3.6.2rc1
python:3.6.2rc1-slim
python:3.6.2rc1-alpine
python:3.6.2rc1-alpine3.6
python:3.6.2rc1-onbuild
python:3.6.2rc1-windowsservercore

JayH5 added 2 commits July 7, 2017 10:28
This reverts commit 576c9e0.

* buildpack-deps images now all have GPG
This reverts commit 6b960f7.

* buildpack-deps images now all have GPG
@JayH5
Copy link
Contributor Author

JayH5 commented Jul 7, 2017

It's tricky because different people have different needs... I don't particularly need Stretch right now, I just wanted to get ahead of the curve. We do still maintain and run a lot of Python 2.7 software. We don't use the Wheezy images (and haven't ever) so I'd be fine with removing those variants. But that's probably not the case for some people 😞.

@owais
Copy link

owais commented Jul 7, 2017

I personally do need stretch got 3.6 because it has never packages and libraries that are not backported. For example gdal which is a dependency for most GIS libraries and framworks like DjangoGIS.

https://packages.debian.org/search?keywords=libgdal-dev. Jessie ships 1.10.1 while a stretch ships 2.1.2. Right now, I must compile the newer version from source on Jessie based image. I'm sure there are more people who would like to have newer libs for their projects and also people who wouldn't want to get newer version without some advance warning so I think perhaps it's best to release another stretch based image and announce a date when default would become stretch and perhaps wheezy would be dropped.

Just my 2 cents.

@youcandanch
Copy link

I also need stretch; I've moved to alpine for a few services simply because Jessie packages are often well out of date at this point. That said, I think if you were looking to cut down on maintenance burden, you could reasonably say that variants for new OS bases only support 2.7 and the most recent minor of 3 (so in this case, you'd have python:2.7-stretch and python:3.6-stretch). Supporting the last version of 2 in extended maintenance feels more important than supporting all the minors of 3.

@tianon
Copy link
Member

tianon commented Jul 17, 2017

Doh, forgot about #104 (folks asking for Stretch + 2.7 specifically). I'm going to go remove those revert commits, rebase this, and get it merged. As usual, thanks for your patience and your contribution, @JayH5! ❤️

@tianon
Copy link
Member

tianon commented Jul 17, 2017

Oh, you did end up still including 2.7 -- I misread the revert commits. 👍

I guess I'll just review this as-is instead! 😅

@tianon tianon merged commit d8cda13 into docker-library:master Jul 17, 2017
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jul 18, 2017
- `ghost`: 0.11.11
- `golang`: minor comment change
- `memcached`: Alpine 3.6, Debian Stretch (docker-library/memcached#24), run tests during build, apply Alpine patch for segfault (docker-library/memcached#22)
- `mysql`: 8.0.2, 5.7.19, 5.6.37, 5.5.57
- `python`: add explicit `jessie` and `alpine3.4` aliases (docker-library/python#215), add `stretch` variant (docker-library/python#208)
- `redmine`: 3.4.2
- `rocket.chat`: 0.57.2
- `ruby`: bundler 1.15.2
tao12345666333 pushed a commit to tao12345666333/python that referenced this pull request Jun 28, 2018
* Try add a Debian Stretch variant

* Update Travis too

* update.sh: Also update Travis file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants