Skip to content

Prevent "silent" failures by having docker-php-ext-configure error on unknown flags so users have to fix them #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

yosifkit
Copy link
Member

@yosifkit yosifkit commented Dec 4, 2019

configure: WARNING: unrecognized options just gets lost in all the configure output

Fixes #917

Users can go back to warn only with --enable-option-checking (gnu autoconf manual):

$ docker-php-ext-configure gd --enable-option-checking --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/

… unknown flags so users have to fix them

"configure: WARNING: unrecognized options" just gets lost in all the configure output
@yosifkit yosifkit merged commit 7fd718d into docker-library:master Dec 4, 2019
@yosifkit yosifkit deleted the error-over-warn branch December 4, 2019 23:24
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 5, 2019
Changes:

- docker-library/php@7fd718d: Merge pull request docker-library/php#918 from infosiftr/error-over-warn
- docker-library/php@9bcb75e: Prevent "silent" failures by having docker-php-ext-configure error on unknown flags so users have to fix them
Teakowa added a commit to FSPNET/PHP that referenced this pull request Apr 10, 2020
Teakowa added a commit to FSPNET/PHP that referenced this pull request Apr 10, 2020
Teakowa added a commit to FSPNET/PHP that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change docker-php-ext-configure to error on unknown configure flags
2 participants