Handle new gd configure options in php 7.4 image #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
PHP 7.4 images are broken due to changes in the
gdextensions configuration flags. See here and here.The reason that this hasn't been picked up before was that the incorrect flags were only producing a
WARNING. We build our images with--quiet, so it was never seen. This behaviour was recently changed toERRORon incorrect configure flags.The final result is that building from the latest
php:7.4-fpm-alpineimage will now fail without the fix in this PR.Changelog Entry
Bugfix - Correctly build gd extension on PHP 7.4
Closing issues
n/a