Update to Debian Stretch and Alpine 3.6, removing erlang-solutions #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
commented
Jun 16, 2017
| @@ -1,10 +1,18 @@ | |||
| FROM debian:jessie | |||
| FROM debian:stretch-slim | |||
There was a problem hiding this comment.
Switching to stretch-slim saves us ~50MB! (from ~177MB down to ~124MB)
yosifkit
approved these changes
Jun 16, 2017
|
One other side effect of this is: Erlang Solutions repository currently installs an unsupported (by released RabbitMQ versions) version which isn't even GA yet (OTP 20-rc2) :/. Not using their repo will make this a non-problem. |
The erlang-solutions repository was used back in 2015 to get us a newer version of Erlang on our then Wheezy-based image -- now that Stretch is stable and ready, we can get 19.x directly from Debian, and thus get multiarchitecture builds as well without additional effort (since the `rabbitmq-server` package is `arch:all`).
|
@michaelklishin oh good catch -- all the more reason to get off that! 😇 |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jun 19, 2017
- `haproxy`: 1.6.13 - `irssi`: Alpine 3.6 (docker-library/irssi#16), multiarch (docker-library/irssi#15) - `python`: 3.6.2rc1 - `rabbitmq`: Debian Stretch and Alpine 3.6 (docker-library/rabbitmq#166), multiarch (docker-library/rabbitmq#167)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The erlang-solutions repository was used back in 2015 (#9) to get us a newer version of Erlang on our then Wheezy-based image -- now that Stretch is stable and ready, we can get 19.x directly from Debian, and thus get multiarchitecture builds as well without additional effort (since the
rabbitmq-serverpackage isarch:all).